From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17106 invoked by alias); 14 Feb 2018 13:55:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16629 invoked by uid 89); 14 Feb 2018 13:55:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=day X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Feb 2018 13:55:37 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 626E27D85D; Wed, 14 Feb 2018 13:55:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C95D4AE7C3; Wed, 14 Feb 2018 13:55:35 +0000 (UTC) Subject: Re: Remove a few more cleanups: solib and openp To: Tom Tromey , gdb-patches@sourceware.org References: <20180213233907.11259-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Wed, 14 Feb 2018 13:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180213233907.11259-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00200.txt.bz2 On 02/13/2018 11:39 PM, Tom Tromey wrote: > This series removes a few cleanups by using unique_xmalloc_ptr. This > also helps clarify the ownership rules of a few APIs. This series > also includes a couple of minor (non-cleanup-related) code clarity > improvements in related areas: moving some declarations out of defs.h, > and a constification. > > Regression tested by the buildbot. Nice! LGTM. Please push. I was wondering whether you'd write patch #1 the other day you touched some of that code. :-) On that patch, you may want to remove the "The returned pathname is malloc'ed and must be freed by the caller." remarks from the intro comments of (at least) solib_find_1, exec_file_find and solib_find (in solib.c). Thanks, Pedro Alves