public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PUSHED] gdb/testsuite: don't include port numbers in test names
Date: Fri, 29 Mar 2024 22:31:16 +0000	[thread overview]
Message-ID: <b5c7f1fd7b9459bbd8b79e7e968aa56b42ff980c.1711751470.git.aburgess@redhat.com> (raw)

The gdb.python/py-cmd-prompt.exp script includes a test that has a
gdbserver port number within a test name.  As port numbers can change
from one test run to the next (depending on what else is running on
the machine at the time), this can make it hard to compare test
results between runs.

Give the test a specific name to avoid including the port number.

There is no change in what is tested after this commit.
---
 gdb/testsuite/gdb.python/py-cmd-prompt.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.python/py-cmd-prompt.exp b/gdb/testsuite/gdb.python/py-cmd-prompt.exp
index a69211ce33d..ccb695f6638 100644
--- a/gdb/testsuite/gdb.python/py-cmd-prompt.exp
+++ b/gdb/testsuite/gdb.python/py-cmd-prompt.exp
@@ -39,7 +39,8 @@ gdb_test_no_output "source $pyfile" "source the script"
 
 set gdbserver [gdbserver_start "" [standard_output_file $binfile]]
 set gdbserver_gdbport [lindex $gdbserver 1]
-gdb_test_no_output "python the_listener.port = '${gdbserver_gdbport}'"
+gdb_test_no_output "python the_listener.port = '${gdbserver_gdbport}'" \
+    "set the_listener.port value"
 
 gdb_run_cmd
 

base-commit: 43f8b6e2578a76fd96bf08172b2ea6fdcaf6c2e4
-- 
2.25.4


                 reply	other threads:[~2024-03-29 22:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5c7f1fd7b9459bbd8b79e7e968aa56b42ff980c.1711751470.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).