From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
Date: Mon, 09 Apr 2018 19:55:00 -0000 [thread overview]
Message-ID: <b5d82b4570f7fcd6fff24f8f42adc72a@polymtl.ca> (raw)
In-Reply-To: <de341f9c-4ba1-fed1-ea04-304cbeae3bb3@redhat.com>
On 2018-04-09 15:35, Pedro Alves wrote:
> On 04/09/2018 08:01 PM, Simon Marchi wrote:
>> On 2018-04-07 02:33 PM, Pedro Alves wrote:
>>> See patch below on top of yours implementing most of the suggestions
>>> above, except the missing comments.
>>>
>>> WDYT?
>>
>> I agree with all your suggested changes. Here is the merged patch I
>> would push.
>> I also changed "test_range_contains" to "test_ranges_contain" to match
>> the name
>> of the function.
>
> Thanks, please push.
>
> Pedro Alves
Done, thanks.
Simon
prev parent reply other threads:[~2018-04-09 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 14:38 Simon Marchi
2018-04-07 14:40 ` [PATCH v2] " Simon Marchi
2018-04-07 18:34 ` [PATCH] " Pedro Alves
2018-04-09 19:01 ` Simon Marchi
2018-04-09 19:35 ` Pedro Alves
2018-04-09 19:55 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d82b4570f7fcd6fff24f8f42adc72a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).