From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C32C63858D3C for ; Tue, 18 Oct 2022 20:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C32C63858D3C Received: from [10.0.0.85] (modemcable162.249-56-74.mc.videotron.ca [74.56.249.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F35B51E0D5; Tue, 18 Oct 2022 16:47:03 -0400 (EDT) Message-ID: Date: Tue, 18 Oct 2022 16:47:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH] gdb: check for groups with duplicate names in reggroups:add Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20221018141733.29298-1-simon.marchi@efficios.com> <87v8ohgeh9.fsf@tromey.com> <87r0z5gdmb.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87r0z5gdmb.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2022 20:47:08 -0000 On 10/18/22 15:01, Tom Tromey wrote: > Simon> I don't think so, because the target description support code creates > Simon> the groups as it finds them while iterating registers. > > Thanks, in that case this seems like a good idea to me. > > Tom I am asking, because these things are still new, so better safe than sorry: are you fine with me adding your Approved-By? Simon