From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id ECDD63856DE2 for ; Wed, 26 Oct 2022 07:15:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ECDD63856DE2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1FE241F8BE; Wed, 26 Oct 2022 07:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666768521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgJE/r5YdehyaFECVvaJMxG+p85IYo1tI7xPRMYQuf8=; b=eCqFWpscEMYyF9Rps9CWMO1Ikzsae9nG67jy2YW+JU8qDU2ELOH0afPt1tz1iWfg+Gldwd IRZKqcWXrtrj0vSQ9CK0xiqR+tsq8kG4992Zs0QdOjcinu2M0cdcJHuro9YapjqYek1Qze twks1xEPxPNC3l1+ztKJibCsZE6rUNk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666768521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgJE/r5YdehyaFECVvaJMxG+p85IYo1tI7xPRMYQuf8=; b=CMvvicb4JrsDWpOSEHahWGDh3//Ns5T/9S8XLsD0uzTT3NNZovOywI2I1xYB8RZbb5Riaa oSoqROGZPFf4jxDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EF42513A6E; Wed, 26 Oct 2022 07:15:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7iUzOYjeWGNnGAAAMHmgww (envelope-from ); Wed, 26 Oct 2022 07:15:20 +0000 Message-ID: Date: Wed, 26 Oct 2022 09:15:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdb/testsuite: fix gdb.guile/scm-parameter.exp "wrong type argument" test pattern Content-Language: en-US To: Simon Marchi , "Maciej W. Rozycki" , Simon Marchi Cc: gdb-patches@sourceware.org References: <20221024164338.1762303-1-simon.marchi@efficios.com> <8ef2b43b-9ac4-3a50-3c93-753c8dcfe001@simark.ca> From: Tom de Vries In-Reply-To: <8ef2b43b-9ac4-3a50-3c93-753c8dcfe001@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/22 03:08, Simon Marchi via Gdb-patches wrote: > > > On 2022-10-24 19:22, Maciej W. Rozycki wrote: >> On Mon, 24 Oct 2022, Simon Marchi wrote: >> >>> I believe that the first two lines are output by Guile itself, in the >>> SCM_ASSERT_TYPE macro. I tried on different systems, different Guile >>> versions (2.0, 2.2 and 3.0) and I always get the former output, never >>> the output the test expects. I presume the patch below isn't right, as >>> there is surely some systems that do print the latter output, otherwise >>> Maciej (the original author) would have noticed it. I presume we'll >>> need to accept both outputs. But I'd like we if could clarify when we >>> get which. >> >> FTR I'm still looking into it and like you I have hesitated to just paper >> the issue over by allowing both outputs without first understanding what >> is really going on here. I cannot rule out a distribution-specific patch >> causing a discrepancy here, but I feel like tracking it down. >> >> NB guile 2.0.13 here, reporting as: >> >> guile (GNU Guile) 2.0.13 >> Packaged by Debian (2.0.13-deb+1-5.4) > > According to that version number, it looks like Ubuntu 20.04? > > https://packages.ubuntu.com/focal/guile-2.0 > > I tried building on Ubuntu 20.04 against guile-2.0, and I see the same > result as you. And when I try guile2.0 on Arch Linux (this package > [1]), I also see the same result as you. So I must have tested it wrong > previously. > > You can dig further if you want, but I'd be fine just accepting both > outputs and saying that guile-2.0 outputs the additional ERROR: while > subsequent versions do not. > FWIW, I did the same here in commit 6bbe1a929c6 ("[gdb/testsuite] Fix gdb.guile/scm-breakpoint.exp with guile 3.0"). Thanks, - Tom