Re: [PATCH v4] gdb/tui/disassembly view: make symbol name appear on a line of its own

[Simon Marchi <simon.marchi@polymtl.ca>]

> This default `false` concerned my initially.  The only times we call
> tui_disassemble is either because we want to redraw the screen
> contents, or we want to know what _would_ be drawn to the screen
> if/when we do the redraw.
> 
> Only, now, we draw the screen differently for these two cases, so, my
> thinking goes, surely there's going to be some edge case where we ask,
> what address would be on the screen if .... and we'll get the wrong
> answer back.
> 
> I played with this for a while, but couldn't get anything obvious to
> break - I suspect that if there are bugs, they are going to be super
> subtle, which addresses appear on the screen doesn't change much,
> usually just one instruction different I think, so maybe it doesn't
> matter.
> 
> And given I couldn't spot anything, maybe I'm over thinking this, and
> there is no problem...
> 
> I guess my question is, did you already consider this already?  Is
> there a reason why having two strategies is known to be OK?

No, I haven't considered this, it is a good question.  I really don't
know the TUI code well (if at all), so my thinking was that if the TUI
experts say it's ok, it's because it's ok :).  But indeed, it would be
good to understand exactly what happens here.

I'll git a little bit.  Vasili, if you happen to know why we have these
two behaviors (for_ui and !for_ui), feel free to answer.

Simon