From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D20743858C31 for ; Wed, 6 Dec 2023 09:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D20743858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D20743858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701855286; cv=none; b=Q/JfCsEzCuj+jxPfV7PbRgjMa67/V4lpH9aPhLyxVVf3XmYYqPuq9S5jv7BYLqY+VSAVVeVRrX+VBxh8PMlzmIvWWOfgTomD8Mcs4c/Krk14hKGXj+Rkg9y43Wwl/QvCCxNqDnDZn+FL6d7bvrHlSL7H/H614f34e4Nt4ytkenM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701855286; c=relaxed/simple; bh=TwqnVq734sEMebmmj1PWzcubWjqXKQP3iOlpHdIS3Mg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Gztv9ZwYBdvGFO5p10YUhXWOkWPWvfTVS+P270nL3J86/qc19sVVhbm/TKcBIW6vLYfiNCuVoX9ZgI952t/8Xr1Fi97y7+7Vvx+KZpGyLhZIqkMQalsoxe+xXggkmgv4juxpJ03OI4viTm7VlkGaLjhvRmzTzXjUB+1q5T1CvsY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B819D21ECB; Wed, 6 Dec 2023 09:34:43 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A014913408; Wed, 6 Dec 2023 09:34:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E6aYJTNAcGXmRQAAD6G6ig (envelope-from ); Wed, 06 Dec 2023 09:34:43 +0000 Message-ID: Date: Wed, 6 Dec 2023 10:34:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][gdb/symtab] Redo "Fix assert in set_length" Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20220922130015.GA25067@delia.home> <87il5cjrgl.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87il5cjrgl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-1.24 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; XM_UA_NO_VERSION(0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.04)[58.97%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Level: X-Spam-Score: -1.24 X-Rspamd-Server: rspamd1 Authentication-Results: smtp-out1.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Rspamd-Queue-Id: B819D21ECB X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/5/23 21:59, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> Hi, > Tom> This reverts commit 1c04f72368c ("[gdb/symtab] Fix assert in set_length"), due > Tom> to a regression reported in PR29572, and implements a different fix for PR29453. > > Tom> The fix is to not use the CU table in a .debug_names section to construct > Tom> all_comp_units, but instead use create_all_comp_units, and then verify the CU > Tom> table from .debug_names. This also fixes PR25969, so remove the KFAIL. > > Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29572 > Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25969 > > Tom> Any comments? > > I've come around on this patch and I think you should check it in. > > My main concern was the time cost, but you showed that this isn't > important; and anyway gdb is probably going to map these sections and do > more stuff with them later anyhow. > > So, I think you should check this in. > The patch no longer applied cleanly, so I've updated it. Also I came across a finalize_all_units call in dwarf2_read_debug_names that was no longer necessary, so I've removed that one. Reposted here ( https://sourceware.org/pipermail/gdb-patches/2023-December/204835.html ) and committed. Thanks, - Tom > Approved-By: Tom Tromey > > Tom