From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DCE023858D39 for ; Thu, 4 Nov 2021 00:43:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCE023858D39 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1A40hLuP020551 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 Nov 2021 20:43:26 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1A40hLuP020551 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6556B1EDDB; Wed, 3 Nov 2021 20:43:21 -0400 (EDT) Message-ID: Date: Wed, 3 Nov 2021 20:43:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: source search with correct return type for "Expression not found" Content-Language: en-US To: Simon Sobisch , gdb-patches@sourceware.org References: <39e16d91-3de3-2558-9afc-9d777eef7edc@gnu.org> From: Simon Marchi In-Reply-To: <39e16d91-3de3-2558-9afc-9d777eef7edc@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 4 Nov 2021 00:43:21 +0000 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 00:43:39 -0000 On 2021-11-03 18:09, Simon Sobisch via Gdb-patches wrote: > Currently the user only gets output of this message, but not error. > The later is especially different handled in GDB frontends and with mi > > gdb/source.c, line 1709: > > - printf_filtered (_("Expression not found\n")); > + error (_("Expression not found")); > > Nice side effect: one msgid less, because on line 1649 it is actually used that way. Hi, Could you please send a proper git-generated patch (using git-send-email, ideally)? Also, in the commit message, please provide an example of the commands you are using, with their output (before and after), explaining what needs to be fixed. Thanks, Simon