From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by sourceware.org (Postfix) with ESMTPS id BC08E3858D3C for ; Thu, 24 Mar 2022 18:09:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC08E3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f51.google.com with SMTP id r64so3217204wmr.4 for ; Thu, 24 Mar 2022 11:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=M5jKMdrvb/hNUF4H11JokzvgKBQ5G5onx+2YTuydzYI=; b=0V6kEFPI9piy8iKk4vppriCRsIQaD7VFKAF5urXGJYU/qs+IdTxPVlv8li0aNrESrt u4Qawc2gWuGxIDdepz65FK1n9/HVgznN0Q+e+UyPjTIlgid/nL8h2GbFKxJWwhwduPB6 SyoTGlnbvDj7w3VI3+i6n+60mA1fMo0HOdMWgNRfVIGp16MO4drKQ3DbrKmFtFRoTcHa W40+O0llA9/6BwrV8HnrIEzhAGONooVTANDnYqkOzTHEiDYle3cRy5Z9Jb6d5FgXsg8a hKz7R2ki26ltbJ2vlZUmRsjZj5x2xqMIbaRuHdc1vZbEmr0ahVGRbnX7CtC2TfNU0USL IOOQ== X-Gm-Message-State: AOAM5305zlh5tTJBqO2+1uhNq6zBjSQJACzXPt+blXtMGmGo7592twgY XtZbzGmVH6HFGp5Q0AbsrNC0il9mZls= X-Google-Smtp-Source: ABdhPJxgrT/1W2IQTHB6NobdBKvzQzFANrf3AYRCWcWawYnSiphkeYpJQKkwldIrtDzJj547giSJ8Q== X-Received: by 2002:a1c:e915:0:b0:37b:d847:e127 with SMTP id q21-20020a1ce915000000b0037bd847e127mr5884173wmc.180.1648145340639; Thu, 24 Mar 2022 11:09:00 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id z18-20020adfec92000000b00203f04ed4a8sm3146723wrn.13.2022.03.24.11.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 11:08:59 -0700 (PDT) Message-ID: Date: Thu, 24 Mar 2022 18:08:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 00/19] Simplify GDB output functions Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220122013801.666659-1-tom@tromey.com> From: Pedro Alves In-Reply-To: <20220122013801.666659-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 18:09:03 -0000 On 2022-01-22 01:37, Tom Tromey wrote: > This series tries to untangle and simplify the GDB output functions. > > By the end of this series, whether a particular bit of output goes > through the filter will largely depend on the particular stream that > is being written to. This means that new code can be much simpler -- > there's no need to decide between using a _filtered or _unfiltered > form of a function, and in fact, that distinction will no longer > exist. (Some unfiltered output is still needed, but only to > gdb_stdout, and only via a single API. New such cases should be > rare.) > > A few cleanups are still possible after this series goes in. For > example, ui-file.c could be broken up a bit, and the pager > implementation should be moved out of utils.c. I also have a couple > of pager bug fixes that I will apply afterward. > > This series is based on a couple of still-pending output series that > I've already sent. I'll probably check those in reasonably soon. > > Regression tested on x86-64 Fedora 34. I hadn't seen this yet, but now that I did, I excitingly skimmed it. I sent nit picking comments to patch #18, but otherwise it all looks great. Thanks a lot for doing this.