From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] gdb: LoongArch: Fix code style issues
Date: Mon, 25 Jul 2022 15:46:20 +0800 [thread overview]
Message-ID: <b6d5c1db-fd0c-570b-17fb-09ed19e15b19@loongson.cn> (raw)
In-Reply-To: <1658224962-21507-1-git-send-email-yangtiezhu@loongson.cn>
On 07/19/2022 06:02 PM, Tiezhu Yang wrote:
> Fix some code style issues suggested by Tom Tromey and Andrew Burgess,
> thank you.
>
> (1) Put an introductory comment to explain the purpose for some functions.
>
> (2) Modify the the attribute code to make it portable.
>
> (3) Remove globals and pass pointers to locals.
>
> (4) Remove "*" in the subsequent comment lines.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> gdb/loongarch-tdep.c | 325 ++++++++++++++++++++++++++++-----------------------
> 1 file changed, 177 insertions(+), 148 deletions(-)
If no more comments, let me push this patch tomorrow,
and then I can make new patch related with this file.
Thanks,
Tiezhu
prev parent reply other threads:[~2022-07-25 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 10:02 Tiezhu Yang
2022-07-25 7:46 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d5c1db-fd0c-570b-17fb-09ed19e15b19@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).