From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2071.outbound.protection.outlook.com [40.107.8.71]) by sourceware.org (Postfix) with ESMTPS id CD2E63858D20 for ; Wed, 13 Sep 2023 14:46:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD2E63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bi/AjTBwDlR/sq6E+t/TnOgNS8fTwvySlh7v0Fri7Xc=; b=E37gONWXGEGWEWuGBym+HSMIjQLIvfwv880c6uGzYlIKet2mZH9vkSlWYwNkzjyovLU8W8nZgtowE6X0wYMT2H4YMBQEJQoSGYxIlEj75t9E47dAIrUkQxVfotp/TGo1sSHCEt2UWcfTu4uQxwHNaBJcPkfh/3NZRM0vFu3LzPk= Received: from DU2PR04CA0257.eurprd04.prod.outlook.com (2603:10a6:10:28e::22) by AS2PR08MB10055.eurprd08.prod.outlook.com (2603:10a6:20b:645::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Wed, 13 Sep 2023 14:46:30 +0000 Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::6c) by DU2PR04CA0257.outlook.office365.com (2603:10a6:10:28e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19 via Frontend Transport; Wed, 13 Sep 2023 14:46:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19 via Frontend Transport; Wed, 13 Sep 2023 14:46:30 +0000 Received: ("Tessian outbound 30c9f5e988c5:v175"); Wed, 13 Sep 2023 14:46:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6190f9f53313b255 X-CR-MTA-TID: 64aa7808 Received: from 4a693792e6b0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C23FBAB4-FEFB-4B58-8FF4-62FA15C6F234.1; Wed, 13 Sep 2023 14:46:24 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a693792e6b0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Sep 2023 14:46:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nC3QO5SXbzzfLwr9KbRLT/mmKqEPGUAMqR59s7C4J4L9wgrHWm5d6Q54CoSclNY26EZdLlyLpW55qR96tdzCYQmqc59U2Y2fun0du8Mycs2WH4uG7+au2TBO7ZutzTcdNqiLglUFIw8DWPysNqj0fSV2AUdV9wOQ+ZH0Ae/N6St4Mjyvo//cTrlqbZfushaXhqnz/Qa8KXipxgWQlgx1L3lioTPWeCZO8ljPyxRXrxbu34oH9I/xzpJTpezfAJh9Q7033KlcoJZAmI1iLgQg+4Vr50ov1Y/34jQUT2MK0p9Ol2PZJbquiKmfE/Qg9uhaLePnk/+i6DzWr7/JYmwogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bi/AjTBwDlR/sq6E+t/TnOgNS8fTwvySlh7v0Fri7Xc=; b=Wig4pzBJsYB2pxZXei8Ij9cwjkZ4/XSafitHAf8Qj61OTM7evdNFIRuWPE19qPwsdoDq1NyszVclmO6WsqEk4qTifuV4jC/LEtiZq+rqs2ZkrYLQoqp+Ia5lSuQ707X2zlfma1ui21vkSq0uYDm2KjTq/eXszVriRk6WJwk+etAzm6j4W2PbFZltUMKnR46h5wk+uYekZb7ueToi8lUcqiMYn6XhOiWkXsTHnWMdmV6nrBfTvie14SY4arQPJTxVhJPDRmB0wD5+qm2XfovAvjM+JHmqAq2gpD6kZ06OKBkgFcdWy6ETyFCz6Cq+5TZk/TZ9E7lVnneozMfs5d6l5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bi/AjTBwDlR/sq6E+t/TnOgNS8fTwvySlh7v0Fri7Xc=; b=E37gONWXGEGWEWuGBym+HSMIjQLIvfwv880c6uGzYlIKet2mZH9vkSlWYwNkzjyovLU8W8nZgtowE6X0wYMT2H4YMBQEJQoSGYxIlEj75t9E47dAIrUkQxVfotp/TGo1sSHCEt2UWcfTu4uQxwHNaBJcPkfh/3NZRM0vFu3LzPk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB9295.eurprd08.prod.outlook.com (2603:10a6:20b:599::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Wed, 13 Sep 2023 14:46:22 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2%6]) with mapi id 15.20.6792.019; Wed, 13 Sep 2023 14:46:22 +0000 Message-ID: Date: Wed, 13 Sep 2023 15:46:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v6 16/17] [gdb/testsuite] sme: Add SVE/SME testcases Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20230913101815.178154-1-luis.machado@arm.com> <20230913101815.178154-17-luis.machado@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0088.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB9295:EE_|DBAEUR03FT048:EE_|AS2PR08MB10055:EE_ X-MS-Office365-Filtering-Correlation-Id: f181a680-43ec-4619-9ffa-08dbb46837ae x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DpwqYXYEYWS4jQJEjAnlsoo0qgisSi8E3NPy/Udv8DWNoTajXI4IQJgr8Vn8fbj1drOv9AGXvefDt9ZukGPUuQCEqwE7OKO6mvJP5odaPD8Ub6BZqgaUgO2pRInWWQ4HZf24gHlRpl6F0R+BsWg8pNY2Kh40mMRvVb0JyR5/xiePnHvjV5QZu1dsNTUQfkKgxGMYfipoTb8A0vugp4Wt66cA4HdAL9co1F3Ecglls39y8/v0F9StS4ZM31gzXCoJ02eh7GqnSOHKivq/SlprMrkGDDVwPJk2an031/sxDIY5bwSymHaG8gWR/870vDm1TKUqh0LxTwboJpLGH7xFz3252Oi8n3shTtf5eLMmwb8bPEoj6Fu9ctSeoQ0LaHswohYmXNQCSW+wr4frmqGauXStWhTIhTPZ4eLdRzuzbOklM6VxPCFNHUSkodlVDQbkFhXFLwMER4aLH+PjBjHDISZ5JsZwSezg9LTOPq7D/4o7EWkb2j5qH4Punws0X7eEqS9MnCcjKyW3VGVbAeZgtFa7PSos6s8sqqMTJV2yxfJmI/I5ZaN+Yrm3ndxwVvPJpJmmRB8PHYLsELfNfDz7I/vHqHVCpDebk0xZhkhZtSVGMC7yuFwuPgJviHRvbw4bcOqkuQ7O9RNcB8wCezTW1w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(136003)(396003)(346002)(376002)(186009)(451199024)(1800799009)(316002)(66476007)(66556008)(66946007)(26005)(2616005)(83380400001)(53546011)(6512007)(6486002)(6506007)(6666004)(31696002)(38100700002)(86362001)(478600001)(2906002)(36756003)(31686004)(4326008)(8676002)(8936002)(41300700001)(44832011)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9295 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7da5e3bf-71bc-4b98-a161-08dbb4683259 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AwLaEA4t7fPLBlx903lG98UzjwgejEdbAlc9kowzQzi4NqHWYCiFha/YX9XyFk3FkoKs6g85yvaJvqagD7c2vwkWrBabJ8NFc6jdZ3WD6NIXzT2DywXo4CATwKS4EfCmWWJasCYeq6VbVUL2W+ablLOTYsZ6EzxSeh2WpekNJnIE6TcSBmgZISEsA69jQvGUcQmNiefaVPoMTrL8uaMA18OTAMzLxo2pqF13xOgCBbIxKr0IwlTh5AbP6IfrkjpJzwC4bZCn3FLzqpw2hJ7U0P+s4hR9bQw8Tbzqz3IkLHFYd3tVlK+o35ZmTOdX2UMqSwPdjILT2YhO17qK/oDyRBWZbqskSERp2xotU+0h9GUG0BS/K6J91XVmAHLUBYa4Tv6gEKchPxrXTyBYGD5IRDhfQh8JHTuZw2k4Tl6lSqMZGw/F6E6xx04EjY7mgQeVQhVfS6zpbMLJjR6t3z0dF7ckoN7khEMIobKc6AlZjVFFulnDgNftdHLxnYjbBc8uYIL322BhFi6+13UJjJRwqBLYf0OjvWKWba+0zPDOQqhLbOwEV1Of0Lr64xBVQ5NPmxoaAzl7itxwR9J19Mrp9wbdci/ph6MfhPw3/383q7LJC4FlImc6217Y1SnAZWCAtddig/u29CwxdRXUVnbyf2Rgr4StAn7eauU83A9wknQgLZR9rwp8GI27ywveIjZfXQGIDV2KO2Bx5GLRYt2YtdzuvoMAZ/iZCm//9d/lO5qOlIxXmcFW/MxllQVi/nIUlWex8Wdn0dt5YE6CnAIqqA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199024)(186009)(82310400011)(1800799009)(36840700001)(40470700004)(46966006)(41300700001)(81166007)(31686004)(6486002)(6506007)(40460700003)(6666004)(53546011)(86362001)(36756003)(356005)(31696002)(82740400003)(40480700001)(47076005)(36860700001)(2616005)(336012)(2906002)(478600001)(83380400001)(6512007)(5660300002)(26005)(107886003)(8676002)(8936002)(70586007)(4326008)(316002)(44832011)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 14:46:30.6846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f181a680-43ec-4619-9ffa-08dbb46837ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10055 X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/13/23 15:34, Simon Marchi wrote: > On 9/13/23 06:18, Luis Machado wrote: >> v3: >> >> - Additional documentation for some testcases based on upstream reviews. >> - Addressed upstream review comments. >> >> v2: >> - Introduced a couple helper functions to determine the available SVE and SME >> vector lengths. >> >> - Before running a batch of tests, validate that the target supports a certain >> SVE vector length or SME streaming vector length. If not supported, skip >> that batch of tests. >> >> - Fixed up native core file testing to remove generation of a spurious core >> file, which later would be reported as unexpected by the testsuite. >> >> - Fixed tpidr2 dump in core file tests. >> -- >> >> Add 5 SVE/SME tests to exercise all the new features like reading/writing >> registers, pseudo-registers, signal frames and core files. >> >> - Sanity check for SME: Gives a brief smoke test to make sure the most basic >> of features are working correctly. >> >> - ZA unavailability tests: Validates the behavior/content of the ZA register >> is correct when no payload is available. It also exercises changing the >> vector lengths. >> >> - ZA Availability tests: These tests exercise reading/writing to all the >> possible ZA pseudo-registers, and validates the state is correct. >> >> - Core file tests: Validates that core file reading and writing works >> correctly and that all state dumped/loaded is sane. This is exercised for >> both Linux Kernel core files and gcore core files. >> >> - Signal frame tests: Validates the correct restoration of SME/SVE/FPSIMD >> values across signal frames. >> >> Since some of these tests are very lengthy and take a little while to run >> (under QEMU at the moment), I decided to parallelize them into smaller >> chunks so we can throw some more CPU power at them so they run faster. >> >> I'd still like to add a few more tests to give the testsuite more coverage >> in the areas of SME/SVE. Hopefully in the near future that will happen. >> >> Just a reminder that most of these tests will FAIL when running against >> gdbserver because all of the tests change the vector length mid-execution >> in some way. Since gdbserver can't communicate the change of state over >> RSP to GDB, we will always get wrong state from gdbserver. > > Is it possible to determine the circumstances when they will fail and > kfail them? It's not good practice to add known failing tests. Yes, as long as we can determine that gdb is talking to a remote target, we can then assume we will have a lot of failures. Those should technically go away whenever we fix the communication of changes to the vector length over RSP (Thiago was looking at it). I seem to recall there was a bit of an unfortunate situation when trying to tell if we were talking to a debugging stub in extended gdbserver remote mode. Is that still the case? Otherwise this should be fairly simple to address. And it may be a better idea to just bail out as opposed to trying to run the tests that are known to fail. When the RSP situation is solved, we can lift this restriction along with it. Thoughts? > > I just skimmed the code, but since some of it is deep AArch64-specific > stuff, I can't review it properly without spending days on it. But > overall it seems well structured and well commented. > > Simon