From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 624663858C62 for ; Mon, 28 Nov 2022 17:45:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 624663858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASHI7GG003458; Mon, 28 Nov 2022 17:45:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=/nYq16d0S76bFSHolXVNR1sTvWEVfVAHauTPERPvd0E=; b=E3mSe2HvXyvore+VPVlYchNmdkxDkf9vhgOsfOA8FVRoyZuW/Ra19KCQfJ5R8P5u1Sap etw8auTcvx3SLleghcbnKKlyoSns30Is6CIOAjrf1dYT/9hJSXYQ676uvYzPxbDiZ1nE FIsfuBuu/8InjLWEkXEM+FO1phAJw5z1CavN2P2Hj2tZU2K5zCQ70aTgw6sOuslgn/lf 0Rgjty6zi+9kGHvit5cGIunffHdZ/Gwh+/0Qs8zW87l+9cg6BnY9XDq2/cgA3PQeErHo /2rtn775vZ7pi8LgXmOnYrFnik5m/FKzv27GRap+jrJG+Pc2GoaZBaV9F7fL8zrPLeGL DA== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m3vpm4gwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 17:45:29 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2ASHLQXQ020982; Mon, 28 Nov 2022 17:45:28 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma03wdc.us.ibm.com with ESMTP id 3m3ae973qm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 17:45:28 +0000 Received: from smtpav05.dal12v.mail.ibm.com ([9.208.128.132]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2ASHjRwr42664526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Nov 2022 17:45:27 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF6515806B; Mon, 28 Nov 2022 17:45:26 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FD4B58068; Mon, 28 Nov 2022 17:45:26 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Nov 2022 17:45:26 +0000 (GMT) Message-ID: From: Carl Love To: Tom de Vries , gdb-patches@sourceware.org Cc: Ulrich Weigand , cel@us.ibm.com Date: Mon, 28 Nov 2022 09:45:26 -0800 In-Reply-To: <20221128162134.20424-1-tdevries@suse.de> References: <20221128162134.20424-1-tdevries@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: X_4ZxR7I-WndoJnGOHy-X6lhcEM5-Llu X-Proofpoint-GUID: X_4ZxR7I-WndoJnGOHy-X6lhcEM5-Llu Subject: Re: [pushed] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_15,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 mlxscore=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280128 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: On Mon, 2022-11-28 at 17:21 +0100, Tom de Vries wrote: > On powerpc64le-linux, with test-case > gdb.ada/out_of_line_in_inlined.exp I run > into: > ... > (gdb) run ^M > Starting program: foo_o224_021-all ^M > ^M > Breakpoint 1, 0x0000000010002f48 in foo_o224_021.child1.child2 > (s=...) at \ > foo_o224_021.adb:24^M > 24 function Child2 (S : String) return Boolean is -- > STOP^M > (gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=all: \ > run to foo_o224_021.child1.child2 > ... > > The breakpoint is correctly set at the local entry point, and given > that the > local entry point doesn't correspond to a line number entry, the > instruction > address of the breakpoint is shown. > > The problem is that test-case doesn't expect the breakpoint address. > > Fix this by allowing the breakpoint address to occur. > > Tested on powerpc64le-linux. > --- > gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > index 4bdb4decaaf..621b04e179b 100644 > --- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > +++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp > @@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} { > > gdb_run_cmd > gdb_test "" \ > - "Breakpoint $decimal, foo_o224_021\\.child1\\.child2 > \\(s=\\.\\.\\.\\).*" \ > + "Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 > \\(s=\\.\\.\\.\\).*" \ > "run to foo_o224_021.child1.child2" > > set opt_addr_in "($hex in)?" > > base-commit: 76cd77dc729b03d6b33c683323594479e33a3f9a The commit fixes the two test failures when run on my Power 9 box. The test runs without any errors on Power 9 with the fix. However, with the commit to fix the test on Power 10, I see the following failures: (gdb) run Starting program: /home/carll/GDB/build-test/gdb/testsuite/outputs/gdb.ada/out_of_line_in_inlined/foo_o224_021-all [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Breakpoint 1.1, foo_o224_021.child1.child2 (s=...) at /home/carll/GDB/binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_\ in_inlined/foo_o224_021.adb:27 27 Do_Nothing (C); (gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=all: run to foo_o224_021.child1.child2 ... Breakpoint 1 at 0x10011870: foo_o224_021.child1.child2. (3 locations) (gdb) run Starting program: /home/carll/GDB/build-test/gdb/testsuite/outputs/gdb.ada/out_of_line_in_inlined/foo_o224_021-minimal [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Breakpoint 1.1, foo_o224_021.child1.child2 (s=...) at /home/carll/GDB/binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_\ in_inlined/foo_o224_021.adb:27 27 Do_Nothing (C); (gdb) FAIL: gdb.ada/out_of_line_in_inlined.exp: scenario=minimal: run to foo_o224_021.child1.child2 I backed the gdb tree up to the previous commit on Power 10 with the command: git checkout af31506c31a59a6edbb13498d6075fa704b801cd and re-ran the tests. I see the same two failures. These failures appear to be different than the ones that Tom reported and fixed with the commit. >From discussion of previous test fixes, there may be a system configuration difference here: My Power 10 system: Fedora release 36 (Thirty Six), gcc (GCC) 12.2.1 20220819 (Red Hat 12.2.1-2) Power 9 system: Ubuntu 20.04.5 LTS, gcc (Ubuntu 9.4.0- 1ubuntu1~20.04.1) 9.4.0 >From what Tom reported on another test, he is running on (openSUSE Leap 15.4) has system gcc 7.5.0. Carl