From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B64C33858CDB for ; Wed, 17 Jan 2024 08:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B64C33858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B64C33858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705481664; cv=none; b=VcD+sfzTXlqcXVd44pi7yEgik/EPA1v6VTUAr6qFZHSPLXeMVEUgRJKNeGTnhb7Oq2W8ryLKU47Q0G3efAYnvoNsFuOUGl7WXVAYqcmSywPBqeFgb/lqmX7z+C1eXP2ku2aL6t/SxOeW/HcUbB9HnKLBjtkSSgrmdou87Z10VJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705481664; c=relaxed/simple; bh=scUG4iSlqAM+20ZwqV89AhDKf4DaFgDvey/JsrtWpeE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JBArlF+A6OO0smMs4U9Fd+AAjXqRcz/2uaM9mFcPZ1z6HomgzOWkm++5vJ7iUpyvtkYSCXNrOVcnRgytfpGeZrM1DV2kT2mVpP+/sZdAGNTRajMqFARSjSrFJkWjIlFns4g+z9jtpV/oUx0fffTttu6rYqxEsfdI1xz8KDEzNco= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705481660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ri2QC77Vi/9VeEYpLBCd4/c39ddWHt3KRTRyYP4Rz0=; b=WY0i8q6cat3pI0pc8PCBibhH4sUlfVughZZrhuyYp8BmX+xk2CkivV0Jqkn7n0e1gvWn4v K+H+fhTqmYMmpR5pEq7pku8inpVWRD7I0EQfWdX/uX5UwEYaJeKvQedN3IMR6ADxlKmvfa PWsP3z/acFYfxKCF0AimZLfuVVi/A74= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-ya6rhI-gOHCqrawgVPMPiQ-1; Wed, 17 Jan 2024 03:54:13 -0500 X-MC-Unique: ya6rhI-gOHCqrawgVPMPiQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a2e66e80504so60067566b.0 for ; Wed, 17 Jan 2024 00:54:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705481652; x=1706086452; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6ri2QC77Vi/9VeEYpLBCd4/c39ddWHt3KRTRyYP4Rz0=; b=uWbfn25m3hnUXjEZJ3VbqlGAmUg+KufDXPRotX50iLe+02L2Fev7gqmGtpUHsj3vrE TW+RyD3aoOxarb5IUchmOt78/mE3S0o54iTjekrlBjFvEB7b/B2dfyjx+oCj7ODktmB6 +IFYa7UpKfcm1gJ7In1kEV4qZaxh6hkGSxUyzG+ky9hKuOjIq5Iw2AP5UgD25Q+6uugb +iUNSLJMsJSXJkdFLmWCgqx8H0g8K/KfuQ76G+8caTRxac70vZCqmbEnbBgSBoIYrZ6d G3oDYG0bwdjb8a/pDZwwi4U7zr2+aYq5BkXOFc3kItgbxZreRsJs5TbtqyMUcSMPP8tM iodA== X-Gm-Message-State: AOJu0YxhBpAg30Em3Lb//FuvwYcRWkCCM+0wxW6KpisBE4r5GMZBCzzN JpY0AA9QUC2o+DP6OfAZ4xS1X9POlPANq67jaOqjRE3ECFZbHssdRP4N2boQLjim+tZZDj0hkdE z3xz/o3QeraJmjVcX2GFaXcOe/sbdPhpuxvPCiA== X-Received: by 2002:a17:907:2da1:b0:a28:5901:70dd with SMTP id gt33-20020a1709072da100b00a28590170ddmr5924462ejc.17.1705481651986; Wed, 17 Jan 2024 00:54:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6pd51E9LuWGF9AyrdCgVAGTyU1qtLbF1qHUHjnPROew7gc0WV10V3zUl4mSpje+YfmlMbxw== X-Received: by 2002:a17:907:2da1:b0:a28:5901:70dd with SMTP id gt33-20020a1709072da100b00a28590170ddmr5924455ejc.17.1705481651536; Wed, 17 Jan 2024 00:54:11 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id ks19-20020a170906f85300b00a2b086c29e1sm7514283ejb.127.2024.01.17.00.54.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 00:54:11 -0800 (PST) Message-ID: Date: Wed, 17 Jan 2024 09:54:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: modernize gdb.dwarf2/dw2-noloc.exp To: Guinevere Larsen , Gdb-patches References: <20240103171605.1048532-1-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: <20240103171605.1048532-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/01/2024 18:16, Guinevere Larsen wrote: > The test gdb.dwarf2/dw2-noloc.exp predates the dwarf assembler, and uses > some unreliable assumptions about where global labels get put. > Specifically, when using clang to compile the test, both labels it uses > to gauge the adresses of the main function get reshuffled to be side-by-side, > and the debug information ends up making it look like main's high pc is equal > to low pc, meaning we never enter the main function's scope, and that leads to > 22 failures because the "main_*" variables are technically never in scope. > > This patch modernizes the aforementioned test to use the dwarf > assembler, which removes all failures when using clang. It also renames > the .c file to be more inline with current standard. Ping! > --- > gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c | 28 -- > gdb/testsuite/gdb.dwarf2/dw2-noloc.S | 331 ---------------------- > gdb/testsuite/gdb.dwarf2/dw2-noloc.c | 44 +++ > gdb/testsuite/gdb.dwarf2/dw2-noloc.exp | 192 ++++++++++++- > 4 files changed, 235 insertions(+), 360 deletions(-) > delete mode 100644 gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c > delete mode 100644 gdb/testsuite/gdb.dwarf2/dw2-noloc.S > create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-noloc.c > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c b/gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c > deleted file mode 100644 > index 9c080fa36b3..00000000000 > --- a/gdb/testsuite/gdb.dwarf2/dw2-noloc-main.c > +++ /dev/null > @@ -1,28 +0,0 @@ > -/* This testcase is part of GDB, the GNU debugger. > - > - Copyright 2009-2023 Free Software Foundation, Inc. > - > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU General Public License as published by > - the Free Software Foundation; either version 3 of the License, or > - (at your option) any later version. > - > - This program is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - GNU General Public License for more details. > - > - You should have received a copy of the GNU General Public License > - along with this program. If not, see . */ > - > -asm (".globl cu_text_start"); > -asm ("cu_text_start:"); > - > -int > -main (void) > -{ > - return 0; > -} > - > -asm (".globl cu_text_end"); > -asm ("cu_text_end:"); > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-noloc.S b/gdb/testsuite/gdb.dwarf2/dw2-noloc.S > deleted file mode 100644 > index d9e31d30ed9..00000000000 > --- a/gdb/testsuite/gdb.dwarf2/dw2-noloc.S > +++ /dev/null > @@ -1,331 +0,0 @@ > -/* This testcase is part of GDB, the GNU debugger. > - > - Copyright 2007-2023 Free Software Foundation, Inc. > - > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU General Public License as published by > - the Free Software Foundation; either version 3 of the License, or > - (at your option) any later version. > - > - This program is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - GNU General Public License for more details. > - > - You should have received a copy of the GNU General Public License > - along with this program. If not, see . */ > - > - .data > - > - .globl file_locaddr_resolvable > -file_locaddr_resolvable: > - .globl file_locempty_resolvable > -file_locempty_resolvable: > - .globl file_locno_resolvable > -file_locno_resolvable: > - .globl file_extern_locaddr_resolvable > -file_extern_locaddr_resolvable: > - .globl file_extern_locempty_resolvable > -file_extern_locempty_resolvable: > - .globl file_extern_locno_resolvable > -file_extern_locno_resolvable: > - .globl main_local_locaddr_resolvable > -main_local_locaddr_resolvable: > - .globl main_local_locempty_resolvable > -main_local_locempty_resolvable: > - .globl main_local_locno_resolvable > -main_local_locno_resolvable: > - .globl main_extern_locaddr_resolvable > -main_extern_locaddr_resolvable: > - .globl main_extern_locno_resolvable > -main_extern_locno_resolvable: > - .globl main_extern_locempty_resolvable > -main_extern_locempty_resolvable: > - > -resolvable: > - .4byte 1234567890 > - > -/* Debug information */ > - > - .section .debug_info > -.Lcu1_begin: > - /* CU header */ > - .4byte .Lcu1_end - .Lcu1_start /* Length of Compilation Unit */ > -.Lcu1_start: > - .2byte 2 /* DWARF Version */ > - .4byte .Labbrev1_begin /* Offset into abbrev section */ > - .byte 4 /* Pointer size */ > - > - /* CU die */ > - .uleb128 1 /* Abbrev: DW_TAG_compile_unit */ > - .4byte cu_text_end /* DW_AT_high_pc */ > - .4byte cu_text_start /* DW_AT_low_pc */ > - .ascii "file1.txt\0" /* DW_AT_name */ > - .ascii "GNU C 3.3.3\0" /* DW_AT_producer */ > - .byte 1 /* DW_AT_language (C) */ > - > -.Ltype_int: > - .uleb128 3 /* Abbrev: DW_TAG_base_type */ > - .ascii "int\0" /* DW_AT_name */ > - .byte 4 /* DW_AT_byte_size */ > - .byte 5 /* DW_AT_encoding */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "file_locaddr_resolvable\0" /* DW_AT_name */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "file_locaddr_unresolvable\0" /* DW_AT_name */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "file_locempty_resolvable\0" /* DW_AT_name */ > - .byte 0 /* DW_AT_location */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "file_locempty_unresolvable\0" /* DW_AT_name */ > - .byte 0 /* DW_AT_location */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ > - .ascii "file_locno_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ > - .ascii "file_locno_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "file_extern_locaddr_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "file_extern_locaddr_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "file_extern_locempty_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 0 /* DW_AT_location */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "file_extern_locempty_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 0 /* DW_AT_location */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ > - .ascii "file_extern_locno_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ > - .ascii "file_extern_locno_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 1 /* DW_AT_external */ > - > - /* main */ > - .uleb128 6 /* Abbrev: DW_TAG_subprogram */ > - .byte 1 /* DW_AT_decl_file */ > - .byte 2 /* DW_AT_decl_line */ > - .ascii "main\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .4byte cu_text_start /* DW_AT_low_pc */ > - .4byte cu_text_end /* DW_AT_high_pc */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "main_local_locaddr_resolvable\0" /* DW_AT_name */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "main_local_locaddr_unresolvable\0" /* DW_AT_name */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "main_local_locempty_resolvable\0" /* DW_AT_name */ > - .byte 0 /* DW_AT_location */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 7 /* Abbrev: DW_TAG_variable (location) */ > - .ascii "main_local_locempty_unresolvable\0" /* DW_AT_name */ > - .byte 0 /* DW_AT_location */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ > - .ascii "main_local_locno_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 5 /* Abbrev: DW_TAG_variable (bare) */ > - .ascii "main_local_locno_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "main_extern_locaddr_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "main_extern_locaddr_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 2f - 1f /* DW_AT_location */ > -1: .byte 3 /* DW_OP_addr */ > - .4byte resolvable /* */ > -2: .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "main_extern_locempty_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 0 /* DW_AT_location */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 8 /* Abbrev: DW_TAG_variable (location+extern) */ > - .ascii "main_extern_locempty_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 0 /* DW_AT_location */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ > - .ascii "main_extern_locno_resolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 1 /* DW_AT_external */ > - > - .uleb128 4 /* Abbrev: DW_TAG_variable (extern) */ > - .ascii "main_extern_locno_unresolvable\0" /* DW_AT_name */ > - .4byte .Ltype_int-.Lcu1_begin /* DW_AT_type */ > - .byte 1 /* DW_AT_external */ > - > - .byte 0 /* End of children of main */ > - > - .byte 0 /* End of children of CU */ > - > -.Lcu1_end: > - > -/* Abbrev table */ > - .section .debug_abbrev > -.Labbrev1_begin: > - .uleb128 1 /* Abbrev code */ > - .uleb128 0x11 /* DW_TAG_compile_unit */ > - .byte 1 /* has_children */ > - .uleb128 0x12 /* DW_AT_high_pc */ > - .uleb128 0x1 /* DW_FORM_addr */ > - .uleb128 0x11 /* DW_AT_low_pc */ > - .uleb128 0x1 /* DW_FORM_addr */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x25 /* DW_AT_producer */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x13 /* DW_AT_language */ > - .uleb128 0xb /* DW_FORM_data1 */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 3 /* Abbrev code */ > - .uleb128 0x24 /* DW_TAG_base_type */ > - .byte 0 /* has_children */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0xb /* DW_AT_byte_size */ > - .uleb128 0xb /* DW_FORM_data1 */ > - .uleb128 0x3e /* DW_AT_encoding */ > - .uleb128 0xb /* DW_FORM_data1 */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 4 /* Abbrev code (extern) */ > - .uleb128 0x34 /* DW_TAG_variable */ > - .byte 0 /* has_children */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x49 /* DW_AT_type */ > - .uleb128 0x13 /* DW_FORM_ref4 */ > - .uleb128 0x3f /* DW_AT_external */ > - .uleb128 0xc /* DW_FORM_flag */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 5 /* Abbrev code (bare) */ > - .uleb128 0x34 /* DW_TAG_variable */ > - .byte 0 /* has_children */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x49 /* DW_AT_type */ > - .uleb128 0x13 /* DW_FORM_ref4 */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 6 /* Abbrev code */ > - .uleb128 0x2e /* DW_TAG_subprogram */ > - .byte 1 /* has_children */ > - .uleb128 0x3a /* DW_AT_decl_file */ > - .uleb128 0xb /* DW_FORM_data1 */ > - .uleb128 0x3b /* DW_AT_decl_line */ > - .uleb128 0xb /* DW_FORM_data1 */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x49 /* DW_AT_type */ > - .uleb128 0x13 /* DW_FORM_ref4 */ > - .uleb128 0x11 /* DW_AT_low_pc */ > - .uleb128 0x1 /* DW_FORM_addr */ > - .uleb128 0x12 /* DW_AT_high_pc */ > - .uleb128 0x1 /* DW_FORM_addr */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 7 /* Abbrev code (location) */ > - .uleb128 0x34 /* DW_TAG_variable */ > - .byte 0 /* has_children */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x2 /* DW_AT_location */ > - .uleb128 0xa /* DW_FORM_block1 */ > - .uleb128 0x49 /* DW_AT_type */ > - .uleb128 0x13 /* DW_FORM_ref4 */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .uleb128 8 /* Abbrev code (location+extern) */ > - .uleb128 0x34 /* DW_TAG_variable */ > - .byte 0 /* has_children */ > - .uleb128 0x3 /* DW_AT_name */ > - .uleb128 0x8 /* DW_FORM_string */ > - .uleb128 0x49 /* DW_AT_type */ > - .uleb128 0x13 /* DW_FORM_ref4 */ > - .uleb128 0x2 /* DW_AT_location */ > - .uleb128 0xa /* DW_FORM_block1 */ > - .uleb128 0x3f /* DW_AT_external */ > - .uleb128 0xc /* DW_FORM_flag */ > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > - > - .byte 0x0 /* Terminator */ > - .byte 0x0 /* Terminator */ > -#ifdef __arm__ > - .section .note.GNU-stack,"",%progbits > -#else > - .section .note.GNU-stack,"",@progbits > -#endif > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-noloc.c b/gdb/testsuite/gdb.dwarf2/dw2-noloc.c > new file mode 100644 > index 00000000000..42332244e9b > --- /dev/null > +++ b/gdb/testsuite/gdb.dwarf2/dw2-noloc.c > @@ -0,0 +1,44 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2009-2023 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +/* This is the value that all variables should have, here for convenience. */ > +#define VALUE 1234567890 > + > +/* These variables are here so that gcc adds them to the .symtab section > + on its own, instead of needing the DWARF assembler. */ > +int file_locno_resolvable = VALUE; > +int file_locempty_resolvable = VALUE; > +int file_locaddr_resolvable = VALUE; > +int main_local_locno_resolvable = VALUE; > +int main_local_locempty_resolvable = VALUE; > +int main_local_locaddr_resolvable = VALUE; > +/* Despite these variables being marked as external in the debuginfo, if > + we do have them as external, the compiler won't add them to the .symtab > + section. */ > +/* extern */ int file_extern_locno_resolvable = VALUE; > +/* extern */ int file_extern_locempty_resolvable = VALUE; > +/* extern */ int file_extern_locaddr_resolvable = VALUE; > +/* extern */ int main_extern_locno_resolvable = VALUE; > +/* extern */ int main_extern_locempty_resolvable = VALUE; > +/* extern */ int main_extern_locaddr_resolvable = VALUE; > + > +int > +main (void) > +{ > + asm ("main_label: .global main_label"); > + return 0; /* main start */ > +} > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp b/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp > index b10050f59b0..dad89095213 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-noloc.exp > @@ -17,7 +17,197 @@ load_lib dwarf.exp > # This test can only be run on targets which support DWARF-2 and use gas. > require dwarf2_support > > -if { [prepare_for_testing "failed to prepare" "dw2-noloc" {dw2-noloc-main.c dw2-noloc.S} {nodebug}] } { > +standard_testfile .c .S > +set asm_file [standard_output_file $srcfile2] > + > +Dwarf::assemble $asm_file { > + global srcdir subdir srcfile srcfile2 > + declare_labels lines_label > + > + get_func_info main > + > + cu {} { > + compile_unit { > + {language @DW_LANG_C} > + {name $srcfile} > + {stmt_list ${lines_label} DW_FORM_sec_offset} > + } { > + declare_labels integer_label > + set int_size [get_sizeof "int" 4] > + integer_label: DW_TAG_base_type { > + {DW_AT_byte_size $int_size DW_FORM_sdata} > + {DW_AT_encoding @DW_ATE_signed} > + {DW_AT_name int} > + } > + > + DW_TAG_subprogram { > + {external 1 flag} > + {name main} > + {low_pc $main_start addr} > + {high_pc "$main_start + $main_len" addr} > + } > + > + DW_TAG_variable { > + {DW_AT_name file_locno_resolvable} > + {DW_AT_type :$integer_label} > + } > + DW_TAG_variable { > + {DW_AT_name file_locno_unresolvable} > + {DW_AT_type :$integer_label} > + } > + DW_TAG_variable { > + {DW_AT_name file_locempty_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name file_locempty_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name file_locaddr_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol file_locaddr_resolvable] > + } SPECIAL_expr} > + } > + DW_TAG_variable { > + {DW_AT_name file_locaddr_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol file_locaddr_resolvable] > + } SPECIAL_expr} > + } > + > + DW_TAG_variable { > + {DW_AT_name file_extern_locno_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + } > + DW_TAG_variable { > + {DW_AT_name file_extern_locno_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + } > + DW_TAG_variable { > + {DW_AT_name file_extern_locempty_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name file_extern_locempty_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name file_extern_locaddr_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol file_extern_locaddr_resolvable] > + } SPECIAL_expr} > + } > + DW_TAG_variable { > + {DW_AT_name file_extern_locaddr_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol file_extern_locaddr_resolvable] > + } SPECIAL_expr} > + } > + > + DW_TAG_variable { > + {DW_AT_name main_local_locno_resolvable} > + {DW_AT_type :$integer_label} > + } > + DW_TAG_variable { > + {DW_AT_name main_local_locno_unresolvable} > + {DW_AT_type :$integer_label} > + } > + DW_TAG_variable { > + {DW_AT_name main_local_locempty_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name main_local_locempty_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name main_local_locaddr_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol main_local_locaddr_resolvable] > + } SPECIAL_expr} > + } > + DW_TAG_variable { > + {DW_AT_name main_local_locaddr_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol main_local_locaddr_resolvable] > + } SPECIAL_expr} > + } > + > + DW_TAG_variable { > + {DW_AT_name main_extern_locno_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + } > + DW_TAG_variable { > + {DW_AT_name main_extern_locno_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + } > + DW_TAG_variable { > + {DW_AT_name main_extern_locempty_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name main_extern_locempty_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location {} DW_FORM_block1} > + } > + DW_TAG_variable { > + {DW_AT_name main_extern_locaddr_resolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol main_extern_locaddr_resolvable] > + } SPECIAL_expr} > + } > + DW_TAG_variable { > + {DW_AT_name main_extern_locaddr_unresolvable} > + {DW_AT_type :$integer_label} > + {DW_AT_external 1 flag} > + {DW_AT_location { > + DW_OP_addr [gdb_target_symbol main_extern_locaddr_resolvable] > + } SPECIAL_expr} > + } > + } > + } > + > + lines {version 5} lines_label { > + set diridx [include_dir "${srcdir}/${subdir}"] > + file_name "$srcfile" $diridx > + > + program { > + DW_LNS_set_file $diridx > + DW_LNE_set_address $main_start > + line [gdb_get_line_number "main start"] > + DW_LNS_set_prologue_end > + DW_LNS_copy > + } > + } > +} > + > +if { [prepare_for_testing "failed to prepare" ${testfile} [list $srcfile $asm_file] {nodebug}] } { > return -1 > } > -- Cheers, Guinevere Larsen She/Her/Hers