From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CF0FA3858C98 for ; Fri, 5 Apr 2024 15:51:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF0FA3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF0FA3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712332269; cv=none; b=M7pYtxLjfIxFEL8LTp/Xrl6II7DQeDuI7OTGoBmKt5IYNUUzhNuldtA9furG9VsyA3DG6EDgcFB9dTVgRdQVtZSqvNY0zjNyNeUA5XTf3iWkPoxYq8fLHZuDmIKsTBPZ23/EcIkmvFkPoh7oV/al2LFurT4pwRLE0TZ0t0gvut8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712332269; c=relaxed/simple; bh=QBwJLgoVCnRQG/farHPz1VfkqCoMGw76mKL7tbcUNJg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SkII+OD3HxyPtp9jFYMCJMSUn/59bvku4o7AarGarRByLtZ/zSlwTrMBiIuwLIYJsltl6d+mqgjqEDuJbGwKqk7zIWc8PTsiDVNCBT+iC94dYyDh4pCbZ2lxcTHGfkc9CIhu/Qpb+I54uHQBhPih5ZQ22F/V+1cknDlNC77kU4g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712332267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TFY6MTiVi5Nwc2wOuON9hqXyGVr/MDbfeM+3SM+wAQ8=; b=HWmpWg4P6Ar4BDW/9SUMuk5sM1dRz+TGl6rGArjVVb5Yq8jRJhtm62oxPeISYU3uiVipi6 ZFcrOiCPwy6eA5bgoIqDI7KZt2INvJAklFKqTg8MwJsHp9Ep6eCMnJYfC+1NC3F01TlFC6 U8/bqorrnRlteipwaZxIU+Jcdxnxxvw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-0YEoHab3NAeOESYY6RXgvw-1; Fri, 05 Apr 2024 11:51:06 -0400 X-MC-Unique: 0YEoHab3NAeOESYY6RXgvw-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-78d39e930c7so283464385a.3 for ; Fri, 05 Apr 2024 08:51:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712332265; x=1712937065; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TFY6MTiVi5Nwc2wOuON9hqXyGVr/MDbfeM+3SM+wAQ8=; b=S820/iQg0S15QPv9AH6SzogkKgB4ru6F73/iEi5KVnmW2HpKRhTSaHXs/J+3K4h59X czMhFgf0fLrf79XfRTBvJwZ7NJ1UHcf6JRXq02IFtf68O45AH9tYbJdNER3yxZLZoWIJ a1sgA+DBazZja7lcFoKECIuugffpTiOLRY2xBTXzkjQ8kr9UYHOz0+T0/wsNw2WGb6yZ AeM8n7+tZzkSVlmR2YKNlxVBm5odbLmcz6fCrt5xjXjRTSlzX2axKOxNRIVuQZpWWjk6 Y0ac7wUgMq2EkFwWEBf068pX0K6/J17hMSwnribcbiB9VHahiyv3tJbrX2RN4ZzEDg9o xmSQ== X-Forwarded-Encrypted: i=1; AJvYcCUGganspuxsuJWxTQDCKQaMsvFw8guI3Xuah1wuN3F00YFCUUEsv0M5bdJCAzX8MqTszSMCJrYFC3Xrrzf7ol5n+XS5olTGCRE8CA== X-Gm-Message-State: AOJu0YzDcKv41qhz3j2RIFSd9TkUeun1xp0K6bo/5bwP9WzkanM1EuLO ou7QhNMF/sfM2ap7/4FvLR1jfOtBdNF4Ua+Zdva/D/h5zjkkEiDxrnTobU76OONc1cNk+ZuvCg1 VzIj9ljvDTwXVbD3LD5ozxY4GR78DjZx1dIsV9u/sr5WdYFqMzv9trjtgQSN2ry4y0x9Qlg== X-Received: by 2002:a05:620a:2a02:b0:78d:492b:808b with SMTP id o2-20020a05620a2a0200b0078d492b808bmr2325057qkp.2.1712332265511; Fri, 05 Apr 2024 08:51:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLAodtV5gY9nWiheeZ9A+n4XWf3KuZ1I0mKMi1eC/wauOLCAB+rBhYb5MHL5dEB3Ju6Lk/Kg== X-Received: by 2002:a05:620a:2a02:b0:78d:492b:808b with SMTP id o2-20020a05620a2a0200b0078d492b808bmr2325042qkp.2.1712332265275; Fri, 05 Apr 2024 08:51:05 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1002? ([2804:14d:8084:92c5::1002]) by smtp.gmail.com with ESMTPSA id qr2-20020a05620a390200b00789e2805f85sm736547qkn.21.2024.04.05.08.51.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 08:51:04 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 12:51:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] gdb, infrun, record: move no-history notification into normal_stop To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <20240312113423.3543956-1-markus.t.metzger@intel.com> <20240312113423.3543956-4-markus.t.metzger@intel.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/24 06:16, Metzger, Markus T wrote: >>> Leave calling gdb::observers::no_history.notify to normal_stop based on >>> the last waitstatus. >> I don't have a problem with this, but I don't really understand why it >> is needed. Do you see any thing that is an actual problem right now, or >> this is just cleanup? > This is to not change current behavior. That's fine, I was just curious. You can add my review tag, Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen She/Her/Hers > > Markus. > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928