From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9177 invoked by alias); 6 Jan 2017 18:31:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9114 invoked by uid 89); 6 Jan 2017 18:31:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:bb26213, H*f:sk:bb26213, H*MI:sk:bb26213 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jan 2017 18:31:04 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cPZI6-0004M7-ST from Luis_Gustavo@mentor.com ; Fri, 06 Jan 2017 10:31:02 -0800 Received: from [172.30.8.13] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 6 Jan 2017 10:30:59 -0800 Reply-To: Luis Machado Subject: Re: [PATCH] Improve load command's help text References: <1483720888-6467-1-git-send-email-lgustavo@codesourcery.com> To: Simon Marchi CC: From: Luis Machado Message-ID: Date: Fri, 06 Jan 2017 18:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00109.txt.bz2 On 01/06/2017 12:29 PM, Simon Marchi wrote: > On 2017-01-06 11:41, Luis Machado wrote: >> diff --git a/gdb/symfile.c b/gdb/symfile.c >> index 61b9e5b..0af1900 100644 >> --- a/gdb/symfile.c >> +++ b/gdb/symfile.c >> @@ -3952,7 +3952,8 @@ that lies within the boundaries of this symbol >> file in memory."), >> c = add_cmd ("load", class_files, load_command, _("\ >> Dynamically load FILE into the running program, and record its >> symbols\n\ >> for access from GDB.\n\ >> -A load OFFSET may also be given."), &cmdlist); >> +A load offset may also be given.\n\ >> +Usage: load [FILE] [offset expression]"), &cmdlist); > > For consistency, I think this would look better: > > Usage: load [FILE] [OFFSET] > > The fact that offset can be an expression can be specified in the text > just before. That sounds good to me. Thanks, Luis