From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A9C393858D20 for ; Wed, 8 Feb 2023 22:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9C393858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2CAB81E0D3; Wed, 8 Feb 2023 17:22:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675894974; bh=/NJ16X9bN0kIim59+Te+DLwHPXRAj3fSMLcKvGP0/Pc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=E+zIK4krPXUxpLlAeO0bVZYskZ92lTk7OyHNXrSNfpAbJZlxxFHaRbSD7+yMPoKY4 pWlPJDrAClZVc/i852TcSp6zP12D5rdVHsHHodGrq3GS+LxT5l0H/mJahEkVGm50uS dpHoVViU2xRVWgicYm5hg3LFqkmc/Z79ao36b2ss= Message-ID: Date: Wed, 8 Feb 2023 17:22:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCHv2] gdb/c++: fix handling of breakpoints on @plt symbols Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <756de5175770d79b3f0642fa3035ef348388bda4.1671544509.git.aburgess@redhat.com> <29e560fd9c94874f0839924fa25557a7e8418ad3.1674215225.git.aburgess@redhat.com> From: Simon Marchi In-Reply-To: <29e560fd9c94874f0839924fa25557a7e8418ad3.1674215225.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Lets consider the 3 symbols GDB created. If the function declaration > is 'void foo ()' then from the main executable we added symbols > '_Z3foov@plt' and '_Z3foov', while from the shared library we added > another symbol call '_Z3foov'. When these are demangled they become > 'foo()@plt', 'foo', and 'foo' respectively. I think the last two should be 'foo()'? I have only looked at the code, not the test. That part LGTM. I was wondering if you could add some unit tests for strncmp_iw_with_mode for this case though. There are already some just below the implementation. Simon