From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28093 invoked by alias); 9 Apr 2018 18:20:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27825 invoked by uid 89); 9 Apr 2018 18:20:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 18:20:21 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w39IKEqn032109 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 9 Apr 2018 14:20:19 -0400 Received: by simark.ca (Postfix, from userid 112) id B987F1EF60; Mon, 9 Apr 2018 14:20:14 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A9F4F1E47D; Mon, 9 Apr 2018 14:20:12 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 09 Apr 2018 18:20:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/5] Copy string_view files from libstdc++ In-Reply-To: <4547b461-76b4-be0f-bf39-ff8cb5c3f631@redhat.com> References: <20180407132629.3787-1-simon.marchi@polymtl.ca> <20180407132629.3787-2-simon.marchi@polymtl.ca> <4547b461-76b4-be0f-bf39-ff8cb5c3f631@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 9 Apr 2018 18:20:14 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00157.txt.bz2 On 2018-04-09 13:39, Pedro Alves wrote: > On 04/09/2018 06:23 PM, Simon Marchi wrote: >> On 2018-04-09 09:44, Pedro Alves wrote: >>> On 04/07/2018 02:26 PM, Simon Marchi wrote: >>> >>>> This patch copies the following files from libstdc++ (commit >>>> 02a4441f002c): >>>> >>>>   ${gcc}/include/std/string_view -> >>>> ${binutils-gdb}/gdb/common/gdb_string_view.h >>>>   ${gcc}/include/bits/string_view.tcc -> >>>> ${binutils-gdb}/gdb/common/gdb_string_view.tcc >>> >>> Nit: the source filenames here should be updated.  Maybe commit as >>> well, if applicable. >> >> Oops, I'm missing "libstdc++-v3" in the source names.  Is there >> anything else wrong with the paths?  What about the commit? > > That too, but I was actually thinking that the files in this revision > were > copied from: > > include/experimental/string_view > include/experimental/bits/string_view.tcc > > instead? Ahh of course, thanks. Fixed locally. Simon