From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44489 invoked by alias); 29 May 2018 15:52:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44259 invoked by uid 89); 29 May 2018 15:52:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:5996 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 15:52:24 +0000 Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 20.AB.10459.4377D0B5; Tue, 29 May 2018 17:52:21 +0200 (CEST) Received: from ESESBMR505.ericsson.se (153.88.183.201) by ESESSHC010.ericsson.se (153.88.183.48) with Microsoft SMTP Server (TLS) id 14.3.382.0; Tue, 29 May 2018 17:52:20 +0200 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESBMR505.ericsson.se (153.88.183.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 29 May 2018 17:52:20 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Tue, 29 May 2018 17:52:20 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.133] (192.75.88.130) by SN6PR15MB2397.namprd15.prod.outlook.com (2603:10b6:805:24::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.797.11; Tue, 29 May 2018 15:52:18 +0000 Subject: Re: [RFA] Remove a VEC from type.c To: Tom Tromey , References: <20180529151002.5700-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 29 May 2018 15:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180529151002.5700-1-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0079.namprd05.prod.outlook.com (2603:10b6:803:22::17) To SN6PR15MB2397.namprd15.prod.outlook.com (2603:10b6:805:24::17) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:SN6PR15MB2397; X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2397;3:fVptx4ozhLvcc+Se4/yteOm6QWEo+VN/bfRCOzSbKJLG0NDzUtaSrfrd8vIpnHEDQnWmG20pIKycdQHw5hsLSM08A8ddBmneWncBoPr0EnwMLjiG5/yzBIhpk0LMBAvty8l4RSvWJ6skHwiwwvjkKjOlJxP1KXc9blmckJf4gzUC0RQUTMxQHmbJPTDfyCCLKaefeIqjN+yXDkE40z/BAunMiw5qxakWjfLvtO2aLGI7DFgqQlCmej1V+2d1vwlk;25:WKUy5jom3ThQyRj5PITXtIr7TPACg0WDVxp7sosMJcKMsuuICCjccJX3b3CgRfRYfITS20r/fZAcNcLu8lrnGjtQT8hhAcmpa0QAsg1KdjsYxZtarUfVVpBLQrp+8foP8TTT5bY6ZV/up5aMdV1RmfJ4ZT99scg54OD3KdYLWhtry3apyKMOdtwWtStpMRTOzvVdONLaC8wJmM9NZlzeAN0nOOy+84wiKK1SkfUgGYOfZCGIHVRWDGAXMLYzh6Gkw5tSVVlVPlogJWQj+CssgDFAk65t0zcUsdnTwk2LdQSTvncckJqZSZZL49B9US8DxXqPrW+cnGNAzwBnXnsI8Q==;31:LSmuM9XCzYBQ2yj24NHKmpvYLvjOEtBUvhaLScQTjTlwIhrB7HCsKqnV5EVbWOKU34l9JJYC+3Lac49baxhh/BvZewJIW+81P10z0V95wwFuMnKr0xMngHfVcshyBfdlQ/5CPYs3SU/PrBzG7LoD4ZDO8tjn0WyF2L3UuARiyd7MrUSI+uE+5pJHrjkTW9cAXz5RpHQBkxAMQ66dIsYxjm9DQJOAlq8muUkn90m33q0= X-MS-TrafficTypeDiagnostic: SN6PR15MB2397: X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2397;20:sqJ75JZZ0yyvDy8m944+2F7iHP4i/+ankwdiUj1cCqTZgXK7PJislAAu9Ja/jgOwE0+7VKL/KjtTdejcliYPq5QbKNlf/a6x0ZrLZMJXtZJ97/wiN8cMKWFb3GdMH3WGQL6d9hmD5M3dKId0YCSiiV0iO9RDKnTw4QCtiqvGJk4GjYkzJCKk6z2tgFrX4OfueYD2M8po1S0uh2iwnKLGnqa7TZiiURH7CZET7W1W3Yf2+ZvOqcU0sfnATvUhNxvPNKukfN6dgWEddh+4LSlLMUSPOmU+o+e/WI5C/M0nhOKNFYyWfDKfsneGlXPoWhPB+kC3MP0724xb8B3MKwbn+GONtD+MTdtK2OMXE3MWOvBa8tNZ6nDfcFB9/edvNAPH5K6iIXCFuPFntaAW/pPFUJ+tZl9cPySLqcdCZ3ihVOtHLT60xcNBHVan1Ab7M1xKVsOOx/JHiCdh+Ksep1RxP3JGA9TOnF7duMpNSL5KpQ8uzTA5jiBmihDyUz3eZyN/;4:qcFvBXnlmJ6eFa4gJD8u09JEeAbu1rs9nOEC1CtKd9cnP78uF4H6FZHjMwaRjLJDm5JZDNCjcckWAVuCo50FFVWRr8jXJAKhJjSupMBJr4Y2cU2hZzqlo3+XINANLPOah8ksP62G5isoh5CRepObv9QJiYHFTk/s499GbxA7AfAR0sUcQQIhRY1HOwrGS20sPSForEa16sIfZiQ7eX8PiNQ8tKR1Q5lA2UTzCQopw4x7fVjUSK9nh/PtrMSUdRUY2QKjvf0wtm28KqtwfCR1Kw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:SN6PR15MB2397;BCL:0;PCL:0;RULEID:;SRVR:SN6PR15MB2397; X-Forefront-PRVS: 0687389FB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(376002)(346002)(39380400002)(366004)(39860400002)(377424004)(199004)(189003)(49976009)(6116002)(31696002)(58126008)(105586002)(316002)(53546011)(76176011)(16576012)(65826007)(386003)(106356001)(8936002)(25786009)(16526019)(5660300001)(50466002)(230700001)(52146003)(2486003)(26005)(6246003)(52116002)(2906002)(64126003)(3846002)(575784001)(23676004)(86362001)(186003)(229853002)(305945005)(53936002)(68736007)(31686004)(7736002)(486006)(6486002)(8676002)(36756003)(44832011)(6666003)(11346002)(81166006)(81156014)(446003)(2616005)(956004)(476003)(66066001)(65806001)(47776003)(65956001)(97736004)(478600001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR15MB2397;H:[142.133.60.133];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjE1TUIyMzk3OzIzOlhpY3NoWEhFTnlMc1RwU21lWlVRNHJUWmh5?= =?utf-8?B?NnZoNnRJQkNxdjB3NVlGbjcvWm5laHM1aXpYS3kyL2U1MS9ENmVtS3BZQ2Rx?= =?utf-8?B?dWNDaGZ3Z2YzMHQrVG5kcUZLMkxPcUY4eVNKMkpLL0J4NUUvdW9qRVA4WUow?= =?utf-8?B?SjRNakNLT09yQnA3bUdTMXdUNkFXZ3A1Ri9rNEtIcjRPZWprRUU4QUlSdDZl?= =?utf-8?B?M016b0JNWlFQaUp2L3dJZFJuZFM3VWg4dGp2MVB4UUtTUFdFVTNxVU1LNXNp?= =?utf-8?B?Sjk4c3Q3Y3NLS25iQ3BGM1RqV3kyZjVHSklHTkxpZGJTRVJvOHRGdHc3UEVk?= =?utf-8?B?TFowQ2M4d0RlYlRkRTlXZEF5MEFYUEYvcDQ4NWk4WWs0TnVkTWlROHV0eURR?= =?utf-8?B?ckxCcUk5NTB5Z3IvT2tzdmJmUHV3SEQ2ZjhkZll3c0QxWHNIRU9YZjNwVDNR?= =?utf-8?B?UUxqWktDMUttZTVEZkY0Z2Z0NFM3cVVWcC9rYm56MmREZElUNXF5YUdqZFJP?= =?utf-8?B?NDIvTmoweXZvQ3dLQitXNTdBZFFUTnhNTW9vQjZyRUhiWVIzVG5ZZ0RnOGtO?= =?utf-8?B?eWZJVFcxa1NTQlczV25IRmxUelJrbzFVWm9lOUx3Q043MjFMZGl5dUxKNzZs?= =?utf-8?B?c3h3anJNb0lpK2JmTzQ1bjY0UmdYdjR3dUlENWp0NURXaVQvU3cwd0pacDZL?= =?utf-8?B?Vy9EazIxVm9MK21BNnlpOGZNSzBMck9pM0c5V3V3NHFvTHhaajZyZXQ3UklL?= =?utf-8?B?M2t4S0N2aXBYN3JkVEtQaU9uYXBMOGRXWUFLM3ZoVXZZdkdYTENYUUtYcm9D?= =?utf-8?B?dFZEL2g4RFRRVjhEUUp1bDRPZSsrZVhDVFB4ZmlSM1pvVGxjaXZVWnducmhs?= =?utf-8?B?aGV2NEtST2t1RWlTVlNKb0hSSU5OMkMyK2RYWjN2TnN4di8wWUtwcmMzU2RD?= =?utf-8?B?cFpyeG54dml5Tk9MWVhsRWZzWGxodmY4RkdPM1JjZkxyQ1pLT3NjcEI2YVE4?= =?utf-8?B?ZXYwNG9iUUtGVGdSdUQwOVNJN2dCY3p2NHgrQVkzcmFOS1J6N0U0TU13Wm05?= =?utf-8?B?SEh5ajMySXg0Qnc2c1lJWUIrNG9iYnBjK291VDBjK0hEUCtDYTRXSUZrQkNP?= =?utf-8?B?RjdHNFFhZGcrTEtzVVBiYnRtVXRucGhYSmhBSU81aVpDOCt3VG1MTGRxdUor?= =?utf-8?B?SnY4SGU1REFpR1lHQkVCaDFQekdSL3dSbjY2QUIxVTZ2MnJOWXM0cjdvY2o3?= =?utf-8?B?dGxXOFBwQVRBb0d1SUFkOTdNOGpUMitud3poaHYrRXE0b282RzhGTHA4MVJ0?= =?utf-8?B?ODZWVGdhOHdubVM2YWNqYVhXdXl4QVVqZUdnQVhiUGkvcVloMmE2dDhNTUZX?= =?utf-8?B?YmVmQWpUODMwN1VGalg0bDEvVzhDMnBhUjFhSDlnVEc0dWhjZlIyOHBHQUdl?= =?utf-8?B?WnNYYzdMNjdGUDZTRXVKVHlrNnErY2VFaU5mTXlSczNORXRzb3R2QlVWWjND?= =?utf-8?B?WDM5eDRtVThZeEd2WHAwZVd1STVvZ3FRUFkySmRPcWQwaEV5N0Vjbmp5RHNn?= =?utf-8?B?U3diczVnMVdGZlI5Nk8xQm4zWm54Z2M3bzlKTnczNXZObVRzQlQwbHdrZnd2?= =?utf-8?B?ZU9LSXM3SG43T2QvYXhKQjg2RE56bkNYdHNRalVFbEM5OXRtaEwyT2JUMWpt?= =?utf-8?B?SVNFSnBoMUoyZVZheXpuWWVMZElhaWhxelpqOElrQXd0VExGMlYraHhxRVVL?= =?utf-8?B?OHp5Ynh2VlRadGQwWTRTSU8vZm5CRWJyWnNBQ0ZqUm9TdCtDUlRlWmRueVZu?= =?utf-8?B?cTdiVlJxak81eGpoZStjZU9WaUgxMVdBK0ZkQjNxalVyYlI4cWNPQ29zZ3Rl?= =?utf-8?B?ZzVxK0hCYjYzekNid29oM0xQSHIwUWIwSGVreEh5MFdabzMyazVQMFkxTnBM?= =?utf-8?B?dnpJcVpBQXArL1lMYld2bXVWWkIvRXNUMTBjVkdDVTg3a091RjJKN05acWVT?= =?utf-8?Q?8bMjAq?= X-Microsoft-Antispam-Message-Info: PFrC8S1Ea/O5F+xS9hH5hRqxbxsqB1S89gBP8YO736FBe6cReHNvvuOQnC6zrMo8ueObQysMiZB15LsliaRtMeIg83FsqIKQd5DOy3W3foupWAl9yS4Qw6JTkeBHf8z7tb1URAbCU2A/3Y3InaioSgpa2MlP0adQOKdAGhWhYsaAVuBMKid8QZjmWQJJtKiu X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2397;6:7MY5nLdSwrqlgDrGHQ1tX7VbQlLyJEkiF8dq2oY3Gj2JAKy8GzxwcXsmqZToj2cpN1v9iMiUDNp+hD4+S9PaQZKGTMi+R8Uo3WHIGIs7Yn9hduv3+Uie/KSIcqlZmzR1FdRs9SYyiVxF26fY63idDqEunHVx5//bFq/PsHxrHk737rhIl/g8Raeg+0Ng+0CiPMisgl0uDQdFnOspULwFP+jhknhxzEqdAK8c9UWO47+5Po38taQbD+Nu/51yoPPVG1vv2bDy9cyiEBvZ2wXeSEtCTONiN45w5tfXFNbwhOJyu0Zxv0mPLVb0gk0ADJJ8e7LoP3oQI8tGzMRylNNONHVDSd3+bBY9TV1hWs/SU12ZhY5+zduNueNJiaplNuVYgexOeXML/rPsGb+sMSdWzgB0LUdVPz333jJSMHcpBtjuXJdFClXI91hPf3CTv4hVxmLMuHl8o4eTPG8yaGF3Hg==;5:d4nCn9scMwbGAX/0PcjAzTSYzy9RGA+yqrUZURMQxwjnqXovoM4DdjZymWXuxiLR7bfW516OlYn30tzcBw/MJiR+M6MQXxMGo6kN07aYMHZL90gE6J0jvS1ZiUw9lAHC5G4zVfDuSB3bd0w0vpFlR9oZPNSKIm+tktlEO9mRN3A=;24:+9kU5oJx4t2XjpjHiiDTY4gIxn7kF0llbmNN0UfVMg70Juif8PdNkzgAeZSP+3nCcA8wUKuyQuIN30GRl3VkKv5ULYinNxQrMRIyDSQBNRE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2397;7:I1I2qY1a6NcsWCNN6R7IRVkBxO4tqrJ3uxMJF7MTU8P58fEirbjujbYb0mIBFTpC4TQLkh6AHNLWBdVLOBPiqx5LbYqaz6WZfWvOuFxRdIzMODk40W1pCRNATNc/esUU4zcV83q6iDEu/jQka2itU90sWc0BU6NJz71+CJ6JmuWHvg3p4YxrxU0NUjpkjnppEIi99CFFc74zGRBGTu0JmfS3cTmZVoz06BIR0+nEByT8Q/hw3ZUMqe54ynIY1cbH X-MS-Office365-Filtering-Correlation-Id: 1883bdb4-8614-4124-ce47-08d5c57c2839 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2018 15:52:18.0224 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1883bdb4-8614-4124-ce47-08d5c57c2839 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2397 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00766.txt.bz2 On 2018-05-29 11:10 AM, Tom Tromey wrote: > This removes a VEC from type.c, by using std::vector. > > While doing this I also took the opportunity to change > types_deeply_equal to return bool. This caught some weird code in > typy_richcompare, now fixed. > > And, since I was changing types_deeply_equal, it seemed like a good > idea to also change types_equal, so this patch includes that as well. > > Tested by the buildbot. LGTM, I just noted some nits. > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index 4f77a5214e3..2be0d2e97d9 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -3551,10 +3551,10 @@ integer_types_same_name_p (const char *first, const char *second) > return 1; > } > > -/* Compares type A to type B returns 1 if the represent the same type > - 0 otherwise. */ > +/* Compares type A to type B returns true if the represent the same > + type, false otherwise. */ Could you fix the "the" -> "they" typo at the same time? It wouldn't hurt to improve the syntax as well, it reads a bit weird. > -/* A helper function to compare two strings. Returns 1 if they are > - the same, 0 otherwise. Handles NULLs properly. */ > +/* A helper function to compare two strings. Returns true if they are > + the same, false otherwise. Handles NULLs properly. */ > > -static int > +static bool > compare_maybe_null_strings (const char *s, const char *t) > { > if (s == NULL && t != NULL) > - return 0; > + return false; > else if (s != NULL && t == NULL) > - return 0; > + return false; > else if (s == NULL && t== NULL) > - return 1; > + return true; > return strcmp (s, t) == 0; > } Not really related to your patch, but I think we could reduce the number of required comparisons/arithmetic operations by doing if (s == NULL || t == NULL) return s == t; return strcmp (s, t) == 0; Simon