From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1051 invoked by alias); 27 Nov 2018 17:20:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1011 invoked by uid 89); 27 Nov 2018 17:20:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1933, Ping X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Nov 2018 17:19:58 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7140C3078A37; Tue, 27 Nov 2018 17:19:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D01BF80EC; Tue, 27 Nov 2018 17:19:56 +0000 (UTC) Subject: Re: [PATCH v3 0/3] Update FreeBSD's syscall table To: John Baldwin , gdb-patches@sourceware.org References: <20181109200432.84491-1-jhb@FreeBSD.org> <7ffda341-7706-d541-939e-f45a7a3f9bd7@FreeBSD.org> From: Pedro Alves Message-ID: Date: Tue, 27 Nov 2018 17:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7ffda341-7706-d541-939e-f45a7a3f9bd7@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00462.txt.bz2 On 11/26/2018 08:31 PM, John Baldwin wrote: > On 11/9/18 12:04 PM, John Baldwin wrote: >> Relative to V2, this changes the "get syscalls" functions to pass in >> an integer vector by reference to append syscall numbers to. It also >> adds a NEWS entry and fixes some other nits noted by reviewers on the >> V2 series. >> >> John Baldwin (3): >> Change get_syscalls_by_group to append to an existing vector of >> integers. >> Add an optional "alias" attribute to syscall entries. >> Update the FreeBSD system call table to match FreeBSD 12.0. >> >> gdb/ChangeLog | 41 ++++++++++++ >> gdb/NEWS | 5 ++ >> gdb/break-catch-syscall.c | 25 ++------ >> gdb/gdbarch.h | 3 - >> gdb/gdbarch.sh | 3 - >> gdb/syscalls/freebsd.xml | 110 ++++++++++++++++++++++++++------- >> gdb/syscalls/gdb-syscalls.dtd | 1 + >> gdb/syscalls/update-freebsd.sh | 78 +++++++++++++++++++++++ >> gdb/xml-syscall.c | 108 ++++++++++++++++---------------- >> gdb/xml-syscall.h | 20 +++--- >> 10 files changed, 279 insertions(+), 115 deletions(-) >> create mode 100755 gdb/syscalls/update-freebsd.sh > > Ping? Eli signed off on an updated NEWS entry earlier in the thread. Any > further comments on the code changes? This looks good to me, though there's the issue with the non-const references discussed here: https://sourceware.org/ml/gdb-patches/2018-11/msg00351.html https://sourceware.org/ml/gdb-patches/2018-11/msg00441.html https://sourceware.org/ml/gdb-patches/2018-11/msg00443.html https://sourceware.org/ml/gdb-patches/2018-11/msg00444.html BTW: > - > + > ... > + Does "catch syscall 498" catch only freebsd11_mknodat calls, or do we for some reason end up catching calls to 559 as well? I'd expect only 498. What about "catch syscall 559"? Thanks, Pedro Alves