From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove cleanups from ser-mingw.c
Date: Mon, 18 Jun 2018 03:16:00 -0000 [thread overview]
Message-ID: <b7ce9d43-9eee-98eb-e740-1ca783b97848@simark.ca> (raw)
In-Reply-To: <20180614212047.14265-1-tom@tromey.com>
Hi Tom,
LGTM, with some nits.
On 2018-06-14 05:20 PM, Tom Tromey wrote:
> @@ -914,14 +913,12 @@ pipe_windows_open (struct serial *scb, const char *name)
> goto fail;
> scb->error_fd = fileno (pex_stderr);
>
> - scb->state = (void *) ps;
> + scb->state = (void *) ps.release ();
- I think we could remove the cast, unless you think it helps readability.
- I think we could remove the goto fail mechanism now.
>
> argv.release ();
Side note: doesn't this argv.release() look fishy to you? Who ends up owning it?
Simon
next prev parent reply other threads:[~2018-06-18 3:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 21:21 Tom Tromey
2018-06-18 3:16 ` Simon Marchi [this message]
2018-06-18 14:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7ce9d43-9eee-98eb-e740-1ca783b97848@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).