From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109362 invoked by alias); 13 Dec 2017 16:41:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108342 invoked by uid 89); 13 Dec 2017 16:41:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 16:41:32 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDEA749025; Wed, 13 Dec 2017 16:41:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 237B769731; Wed, 13 Dec 2017 16:41:30 +0000 (UTC) Subject: Re: [PATCH 0/3] Fix regression: expression completer and scope operator (PR gdb/22584) To: Simon Marchi , gdb-patches@sourceware.org References: <1513171596-10665-1-git-send-email-palves@redhat.com> <5a439ff4-6f7e-235a-6ce2-2d70eae2387c@ericsson.com> From: Pedro Alves Message-ID: Date: Wed, 13 Dec 2017 16:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5a439ff4-6f7e-235a-6ce2-2d70eae2387c@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00314.txt.bz2 On 12/13/2017 03:57 PM, Simon Marchi wrote: > On 2017-12-13 08:26 AM, Pedro Alves wrote: >> This patch series fixes PR gdb/22584, a regression in the expression >> completer: >> >> "(gdb) p std::[TAB]" => "(gdb) p std::std::" >> >> GDB got confused above, there's no such thing as "std::std::". >> >> Patch #1 factors out some code duplicated throughout the codebase. >> >> The new function patched by patch #1 is used by patch #2 (the actual fix) uses. >> >> Patch #3 fixes something in the new completion testing support >> routines that I noticed while writing the tests for patch #2. >> >> Pedro Alves (3): >> Factor out final completion match string building >> Fix regression: expression completer and scope operator (PR gdb/22584) >> Tighten regexp of >> lib/completion-support.exp:test_gdb_complete_tab_multiple >> >> gdb/cli/cli-decode.c | 41 +---------- >> gdb/completer.c | 115 +++++++++++++++++++++---------- >> gdb/completer.h | 24 ++++++- >> gdb/interps.c | 20 +----- >> gdb/symtab.c | 52 ++------------ >> gdb/testsuite/gdb.cp/cpcompletion.exp | 42 +++++++++++ >> gdb/testsuite/gdb.cp/pr9594.cc | 13 ++++ >> gdb/testsuite/lib/completion-support.exp | 7 +- >> 8 files changed, 169 insertions(+), 145 deletions(-) > > That series looks good to me. Thanks, pushed. Pedro Alves