From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb, gdbserver: make target_waitstatus safe
Date: Tue, 12 Oct 2021 13:28:50 -0400 [thread overview]
Message-ID: <b7efbd4e-ac64-0700-de5b-6cb456097299@simark.ca> (raw)
In-Reply-To: <b4119eb2-84d6-84b5-15bf-a7309fae052e@FreeBSD.org>
On 2021-10-12 1:04 p.m., John Baldwin wrote:
> I think this is a good change. I only read over fbsd-nat.c and I think
> I like the idea. One thing that does stick out to me is the assymetry
> in that we no longer use TARGET_WAITKIND_* for setting the status, only
> when comparing the result of kind(). I wonder if instead you might
> consider adding type specific queries (e.g. is_ignored(), is_forked())
> and removing TARGET_WAITKIND_* as a public interface entirely?
I don't mind giving it a try, but it would be as a separate patch.
Simon
next prev parent reply other threads:[~2021-10-12 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:17 [PATCH 1/3] gdbserver: make thread_info non-POD Simon Marchi
2021-10-12 16:17 ` [PATCH 2/3] gdbserver: initialize the members of lwp_info in-class Simon Marchi
2021-10-12 16:17 ` [PATCH 3/3] gdb, gdbserver: make target_waitstatus safe Simon Marchi
2021-10-12 17:04 ` John Baldwin
2021-10-12 17:28 ` Simon Marchi [this message]
2021-10-13 1:57 ` Simon Marchi
2021-10-13 2:08 ` John Baldwin
2021-10-21 20:15 ` [PATCH 1/3] gdbserver: make thread_info non-POD Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7efbd4e-ac64-0700-de5b-6cb456097299@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).