From: Tom de Vries <tdevries@suse.de>
To: Enze Li <enze.li@hotmail.com>, gdb-patches@sourceware.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [PATCH][gdb/build] Handle deprecation of scm_install_gmp_memory_functions
Date: Thu, 7 Jul 2022 10:20:54 +0200 [thread overview]
Message-ID: <b81c91fd-65bd-2795-10e1-bec7f5763d33@suse.de> (raw)
In-Reply-To: <TYCP286MB216380CE1952A98BF326B67EF0839@TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM>
On 7/7/22 10:14, Enze Li wrote:
> Hi Tom,
>
> Thanks for doing this. :)
>
Np :)
> On Thu, 2022-07-07 at 09:58 +0200, Tom de Vries via Gdb-patches wrote:
>> Hi,
>>
>> When building gdb with guile 3.0.8, we run into:
>> ...
>> gdb/guile/guile.c: In function \
>> 'void gdbscm_initialize(const extension_language_defn*)':
>>
>
> <...>
>
>>
>> Tested on x86_64-linux.
>>
>> Co-Authored-By: Tom de Vries <tdevries@suse.de>
> ^^^^^^^^^^^^^^
> This part confused me. Is it necessary to include such a line when the
> author of the patch is the same person?
>
No, indeed it's not necessary in such a case.
However, that is not the case here, because I'm not the (main) author:
...
$ git show --pretty=fuller -s
commit b47665709cabeb064cd57e1bf21b95d92c68be4e (HEAD -> fix
-guile-build)
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Thu Jul 7 08:20:28 2022 +0200
Commit: Tom de Vries <tdevries@suse.de>
CommitDate: Thu Jul 7 09:54:52 2022 +0200
[gdb/build] Handle deprecation of scm_install_gmp_memory_functions
...
Thanks,
- Tom
> Thanks,
> Enze
>
>>
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28994
>>
>> Any comments?
>>
>> Thanks,
>> - Tom
>>
>> [gdb/build] Handle deprecation of scm_install_gmp_memory_functions
>>
>> ---
>> gdb/guile/guile.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c
>> index 14b191ded62..e5565b627d9 100644
>> --- a/gdb/guile/guile.c
>> +++ b/gdb/guile/guile.c
>> @@ -677,7 +677,17 @@ gdbscm_initialize (const struct
>> extension_language_defn *extlang)
>> "double free or corruption (out)" error.
>> Work around the libguile bug by disabling the installation of
>> the
>> libgmp memory functions by guile initialization. */
>> +
>> + /* The scm_install_gmp_memory_functions variable should be
>> removed after
>> + version 3.0, so limit usage to 3.0 and before. */
>> +#if SCM_MAJOR_VERSION < 3 || (SCM_MAJOR_VERSION == 3 &&
>> SCM_MINOR_VERSION == 0)
>> + /* This variable is deprecated in Guile 3.0.8 and later but
>> remains
>> + available in the whole 3.0 series. */
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>> scm_install_gmp_memory_functions = 0;
>> +#pragma GCC diagnostic pop
>> +#endif
>>
>> /* scm_with_guile is the most portable way to initialize
>> Guile. Plus
>> we need to initialize the Guile support while in Guile mode
>> (e.g.,
>
next prev parent reply other threads:[~2022-07-07 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:58 Tom de Vries
2022-07-07 8:14 ` Enze Li
2022-07-07 8:20 ` Tom de Vries [this message]
2022-07-07 8:30 ` Enze Li
2022-07-08 14:03 ` [committed][gdb/build] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b81c91fd-65bd-2795-10e1-bec7f5763d33@suse.de \
--to=tdevries@suse.de \
--cc=enze.li@hotmail.com \
--cc=gdb-patches@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).