public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix field names of GDB's type main_type structure
Date: Fri, 5 Mar 2021 13:04:59 -0500	[thread overview]
Message-ID: <b82933a7-c003-aa52-9847-301d7bacdd33@polymtl.ca> (raw)
In-Reply-To: <20210224174234.GJ265215@embecosm.com>

On 2021-02-24 12:42 p.m., Andrew Burgess wrote:> Ping!
> 
> The changes in gdb-gdb.py are straight forward.  I wonder if anyone
> wants to comment on the abomination of a test?
> 
> Thanks,
> Andrew

I saw this before but then forgot about it.  First, thanks for fixing
the pretty printer, I always forget to update it.

I think the test is fine (certainly better than no test).  It is
adequately documented / commented, so I would be comfortable debugging
it, if I ever need to (no need to guess "why is it doing that!?").

Thanks!

Simon

  parent reply	other threads:[~2021-03-05 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 22:58 Andrew Burgess
2021-02-24 17:42 ` Andrew Burgess
2021-03-05 17:49   ` Andrew Burgess
2021-03-05 18:04   ` Simon Marchi [this message]
2021-03-09 11:09     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b82933a7-c003-aa52-9847-301d7bacdd33@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).