From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D20C13834423 for ; Fri, 5 Mar 2021 18:05:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D20C13834423 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 125I4xxw016356 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 5 Mar 2021 13:05:04 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 125I4xxw016356 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9F9FD1E54D; Fri, 5 Mar 2021 13:04:59 -0500 (EST) Subject: Re: [PATCH] gdb: fix field names of GDB's type main_type structure To: Andrew Burgess , gdb-patches@sourceware.org References: <20210208225833.98235-1-andrew.burgess@embecosm.com> <20210224174234.GJ265215@embecosm.com> From: Simon Marchi Message-ID: Date: Fri, 5 Mar 2021 13:04:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224174234.GJ265215@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 5 Mar 2021 18:04:59 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 18:05:06 -0000 On 2021-02-24 12:42 p.m., Andrew Burgess wrote:> Ping! > > The changes in gdb-gdb.py are straight forward. I wonder if anyone > wants to comment on the abomination of a test? > > Thanks, > Andrew I saw this before but then forgot about it. First, thanks for fixing the pretty printer, I always forget to update it. I think the test is fine (certainly better than no test). It is adequately documented / commented, so I would be comfortable debugging it, if I ever need to (no need to guess "why is it doing that!?"). Thanks! Simon