From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 2B6B1385B50F for ; Fri, 23 Dec 2022 09:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B6B1385B50F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4A45D3F29D; Fri, 23 Dec 2022 09:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1671786850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=duVrHrIVNME6dM5+MR/TvKbdfP79JJbvQuzlYgP1i50=; b=kOkIYTZVEefNzunfOjjS5CeneHXDkCqsEGFpa6l1ih2BsGOspyl93WzdD5vkV1HMHZBnIP 7eR42NdKx1KplTTMnAHn2yhbBFqhMaTEGtgA6p6BEyBywlBzstuR1XbDZQHwTEs5JJLDLn 2iSp0OZx0INByQ5YLxfnXDDKl6mSAx0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1671786850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=duVrHrIVNME6dM5+MR/TvKbdfP79JJbvQuzlYgP1i50=; b=Ga21dVE5yf8VSvK+e6R2oh+1EoTfP2UduS40feeZ4U+gXa02RsdWXuRtgj71iYQpT8Fb6u elFPWF+RNWWlvkDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 416EF13913; Fri, 23 Dec 2022 09:14:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Wv7KD2JxpWPwagAAMHmgww (envelope-from ); Fri, 23 Dec 2022 09:14:10 +0000 MIME-Version: 1.0 Date: Fri, 23 Dec 2022 09:14:10 +0000 From: tdevries To: Simon Marchi Cc: gdb-patches@sourceware.org, Andrew Pinski Subject: Re: [PATCH] gdb/testsuite: remove MPFR detection in gdb.base/float128.exp In-Reply-To: <20221222151349.2320082-1-simon.marchi@polymtl.ca> References: <20221222151349.2320082-1-simon.marchi@polymtl.ca> User-Agent: Roundcube Webmail Message-ID: X-Sender: tdevries@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TRACKER_ID,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-12-22 15:13, Simon Marchi via Gdb-patches wrote: > I see this fail since commit 991180627851 ("Use toplevel configure for > GMP and MPFR for gdb"): > > FAIL: gdb.base/float128.exp: show configuration > I'm also seeing this. > The test fails to find --with-mpfr or --without-mpfr in the "show > configuration" output. Since MPFR has become mandatory, we can just > remove that check and simplify the test to assume MPFR support is > there. > LGTM. Thanks, - Tom > Change-Id: I4f3458470db0029705b390dfefed3a66dfc0633a > --- > gdb/testsuite/gdb.base/float128.exp | 37 +---------------------------- > 1 file changed, 1 insertion(+), 36 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/float128.exp > b/gdb/testsuite/gdb.base/float128.exp > index 21a1a99f6ee7..73835942ab0c 100644 > --- a/gdb/testsuite/gdb.base/float128.exp > +++ b/gdb/testsuite/gdb.base/float128.exp > @@ -73,40 +73,5 @@ gdb_test_multiple "set var f128=20.375l" "$test" { > gdb_test "print ld" ".* = 10\\.375.*" "the value of ld is changed to > 10.375" > gdb_test "print f128" ".* = 20\\.375.*" "the value of f128 is changed > to 20.375" > > -set mpfr_supported -1 > -gdb_test_multiple "show configuration" "" { > - -wrap -re "--with-mpfr\r\n.*" { > - set mpfr_supported 1 > - } > - -wrap -re "--without-mpfr\r\n.*" { > - set mpfr_supported 0 > - } > -} > - > # Test that we can correctly handle the largest IEEE-128 value > -# Note: If we get "inf" instead of the correct result, we may have run > into > -# an internal overflow. This typically happens on host platforms > without > -# native IEEE-128 support where GDB was built without MPFR support. > -set test "print large128" > -gdb_test_multiple "print large128" "$test" { > - -re ".* = > 1\\.18973149535723176508575932662800702e\\+4932.*$gdb_prompt $" { > - pass "$test" > - } > - -re ".* = inf.*$gdb_prompt $" { > - if { $mpfr_supported == 0 } { > - # If the host platform has native 128-bit float support (as is > - # the case for some versions of s390 and powerpc), the > - # "print large128" test should be passing, even without MPFR > - # support. So, in those cases we should have fail here rather > than > - # unsupported. However, given that we don't have a way to readily > - # test for this, we fall back to unsupported. > - unsupported "$test (Missing MPFR support)" > - } else { > - fail $test > - } > - } > - -re ".*$gdb_prompt $" { > - fail "$test" > - } > -} > - > +gdb_test "print large128" ".* = > 1\\.18973149535723176508575932662800702e\\+4932" > > base-commit: a5ce326cfeb364a33d8ee9c806780347a92b5d18