From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by sourceware.org (Postfix) with ESMTPS id B6ABC3857835 for ; Thu, 8 Apr 2021 01:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B6ABC3857835 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13810ANL061018; Thu, 8 Apr 2021 01:09:32 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 37rvagca7v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Apr 2021 01:09:31 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 138101ZG016656; Thu, 8 Apr 2021 01:09:31 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by userp3030.oracle.com with ESMTP id 37rvbf21th-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Apr 2021 01:09:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcEOMiBoD2fYHOkREjADdcmQnp/cgVVNOyWB1hNardt+mfhAOgd9hrFpz28G30JpGWRnSCkHvVvCR0+rReUBdv7fvIjhSV1mbZ3WAHagBMLSEu20lqq2BqT2tkB4wn5otidlUVgXaWofl0WyyXg6jPPEKvXWODVNPj9kPyGHYCqM5QfORI/6wdrofbawLWxyHn3mNKu9tYjm/NIk9rjJ2HO65HwGwW1IEWMa4pvEnvywL4wy12xfKkEZyMpRYq63lWZQzpYLEe5mgGPcSwfyVDy3OTkFJl/R2v0353ryk/qeW+Ti2/Djd/KG9TUiS9qqRZeiZ9q/qZfa2GOzskMGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rk1Q0WddFITE/EuOBXTsiWBsSKakuAbsgA7wIwk+4nU=; b=gOuNupZ/gQ1L5DKiztBTR2FscBdG1UHueAQ5HLsC2jblKwxcIcPQlkpopxMTp9IHmW/CQULmkwCX8dK5dkmLdWnIPiKBpWjEr2xejhemQymOaWQpmXzA/ZtTQ6MtMsRbCxie9Gj/gn+vgJDaX2f8HluDKfGOIdu+Ho/yZ+9kmmx0WTTPBvbIUgpEDsFARUGU5NBo0s/tAEuv/ZplPyLBLnIUlPAuCmobKbnxeSnLpNHzmuJ2eARoQLUw4oXql9zYa+iZ8m9aE4W7hVb65vcDduVxKD46uAjXBYJEZ8rQZRPzWrWsZCrCTLTzrUNqJ63bgoYwEf6ojrTthgom22cTWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) by BN0PR10MB4902.namprd10.prod.outlook.com (2603:10b6:408:12a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 01:09:28 +0000 Received: from BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::250a:e1c3:3146:8e02]) by BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::250a:e1c3:3146:8e02%9]) with mapi id 15.20.3999.034; Thu, 8 Apr 2021 01:09:28 +0000 Subject: Re: [PATCH,V3 2/3] CTF: handle forward reference type To: Tom Tromey , Weimin Pan via Gdb-patches References: <1617237594-24175-1-git-send-email-weimin.pan@oracle.com> <1617237594-24175-2-git-send-email-weimin.pan@oracle.com> <1617237594-24175-3-git-send-email-weimin.pan@oracle.com> <875z16q6yl.fsf@tromey.com> From: Weimin Pan Message-ID: Date: Wed, 7 Apr 2021 18:09:26 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <875z16q6yl.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [108.88.88.153] X-ClientProxiedBy: BYAPR05CA0058.namprd05.prod.outlook.com (2603:10b6:a03:74::35) To BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.27.35.125] (108.88.88.153) by BYAPR05CA0058.namprd05.prod.outlook.com (2603:10b6:a03:74::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8 via Frontend Transport; Thu, 8 Apr 2021 01:09:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c50cee7-af5e-4a1e-3e11-08d8fa2af4f4 X-MS-TrafficTypeDiagnostic: BN0PR10MB4902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rxrPp6uZwuDTphBz4Wit2t/QQMBgQml7P59DibAoG21cxUZmDUaMaud4Qaa/fgDXMQAFc6LG9qz6eTkTsspIktaGRZgUuFU7pnlFfCANARFTH8IxfXChECA9pt0JfGNpPB47ZlgGpm3l2cb8i3qFuKQx7a9oPIH0lvSkK+mb/mfxcwlNWgPEmOoMMH8J0EIM584vIiKvY4F9NGPaQFSBhg7f14atm5DzPogUm2vvxSR+FDvOEWi+6RFUQeS+kDzZtP4TmhiIczjwODXEwf4dTmY+Uox3FfHr//dBNfIuR2vmyYVUXLLgq6W86ZK8iX0Oeppdu3rK8DIaDc3XHfFc1WO3y2n0aB45U3URLDGTT5j2jZK8awN9x3unUUo3y7EQU2BTC072TT4b1ytTFnD93pE2qT3VDj/Du+KtNV1vvRsR/cE6hLe6kl4WamxLqPdO/CGunL0c4nSFur/Uoa16sS6HU460Y58on2ZxvOB9WT3IuD2kl4qrpn35j4oiSSBLYynonG0gUwLQ4Pzl30b5hgpbeqQWXysTXCmIWQQZDXDLPd5dlnMans8bSjwTGSgnGDZ0OPFQkz6japM+k1dXkJf67K0Snb/4MRK+iYIu8YpxDKHHNcHZ0qGiUYvcU0clJ+maW+lpu4Oosl4VcJJ0+1sjVb6CJzI4f8UcDjwnwQeG8AA1sDUL/R9P5Kx2vI+9cNpSf62ADAeRiN+1ggmSnU3/FQNQ3V8pCGkq/YOme5hoAYk+T//n7SwVcsE/D+bP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR10MB1748.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(396003)(39860400002)(136003)(366004)(8676002)(8936002)(478600001)(6486002)(31686004)(2906002)(52116002)(2616005)(44832011)(38100700001)(956004)(31696002)(86362001)(38350700001)(66476007)(36756003)(26005)(16526019)(186003)(5660300002)(66556008)(16576012)(66946007)(110136005)(316002)(53546011)(4744005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bUNxNXBKaDBqdFN2TTdzeW5mbW9VNVRCaG9nRzk2RDJkbWxlNElwVTNmdXM3?= =?utf-8?B?aTFVNFcreVBYZGtNZG02eVg1enpIRGJRV2RHZSswVkhZb3FZd0QrYXZvNmJp?= =?utf-8?B?NkU5WHBqWWhOZW1JenhDd0xSdS9xeU5OR0VYbU1NRUpLenQxQTRJNFRWVTZq?= =?utf-8?B?OFp4b3VhVlNFWGIvczR4L05IdDdhYVZTK0x2WXdhOUVoSEd3QnFjL2sxanJR?= =?utf-8?B?QnA4eEczN2xHelFzYWhHVDB4My94Qm9LRDFBci9ETmQvZ3hEVDBJQ3N4ZjVm?= =?utf-8?B?bzgvYTRwWnBwM2JwWHVReEN6aTRROG1iWWxXYVNiNCs4RWxtUWgyQnhJaGhF?= =?utf-8?B?cC9qc3psdGFVOXVTcDhPMlhDQWJwMWl1Y0U1K0NwenJ4TGhFZFFIOXV2M1hu?= =?utf-8?B?M3c0ZkJIZHZibzZsb1NicHN2MVFrbkpyVVJwT1FJUWcvMnRKcDhoSDFvclo4?= =?utf-8?B?UEVDbEhja1BiSnJOUkhQWXhxUC9YcUNJazZidUdBeHcyVGJPOEI5TExVdEo2?= =?utf-8?B?R1dnVDlMTmc1NG5Ya1YxZkNEQUN0b1MyU3hBZ21OZWhUNnArL3ptdkFYczdE?= =?utf-8?B?M3FuZEk5dGZwcXhIcmNCNW81ZmNPejV1TjBrd09jWFoxSCtPMHEwbFBFWGRh?= =?utf-8?B?NzZUSlg4VE9PRlJHRlhTT1NrdzBzWEtiOVNML1NGTURWUFk5eUxEN2dMVUtU?= =?utf-8?B?NEdyRXpMMjFtbkQxMERPTUl1TG53SlNqRWNBUllMV2VXZlh2eHVrOENlMWJa?= =?utf-8?B?SksxV2ZpbTZ3c0p6ODN0MGJrSmlIV0o1ZWJ1dU85NWZrRG5GbGVJeG1RSkZF?= =?utf-8?B?Q1dUeks2a1FvSFFGRGtxV0duR2FlWVVZdFV5QU9MazZxNlZnbE9yN3NtWUh4?= =?utf-8?B?Q3VyWUMwaGJVOUZucldEZ0lNVTRadlhZOHNXNkFjUGMrMzFWZTh5WElKSnp2?= =?utf-8?B?RWVuU285N05lK1Zmc3RCVy9PVGM2aFh3OUo3eTUxdGhvT05LU2IydExwL3Iy?= =?utf-8?B?M0sxR2xQQjQxLzBTbmVxc2N4ZkpCdDJyK2NiNjZCbUtDWWZzZDdNSHd3WDFk?= =?utf-8?B?eTd2WFRXWDVIWVVPbHdzYng2SHJXclQyRVQyRVFnVUhyQ0xpWmZuWWRhZ3JX?= =?utf-8?B?VytLOCtvbkUxcWFtckRwSVdBRmFBTmFLalE4TlQ4bTlCa0Z4alJYVDVneFlJ?= =?utf-8?B?Z2VPS09oZXNEdDQ4YzV1YURiNGdqMTZFU2VGNi9GWms0UFJRaE9YK1VMa2FL?= =?utf-8?B?L2hWekFNK1RLU2sxNWxJYnlycDR0TkZyN3l3ZGhVdVJuYkxxZmdGMTFpcDJF?= =?utf-8?B?em1XV2pGR0dHd0llTXB0aldSMkk1b3h2S3llTUpVL3BlSzlWWXk0eGxOMlh3?= =?utf-8?B?M0NWcnRvVExIZjhnanBpKzdzUGpKa3ZzS0J0QUJRcFYxNWNvUjh1L2xHMTUr?= =?utf-8?B?NE5pMjczMWNSanBnTTVWTG5GUlFjOWlvYWU4eXJ6VUx0bk5wZkp2MDFTTEFy?= =?utf-8?B?VzJBZjI0Q3ltcmM1T2d1SXNDNmtzb1hEZnpDY1lkenRqNTh5TUdqOURyWU9P?= =?utf-8?B?bFNZd2VqRWc3Ky9DaXdpNElPTTNVaUExN1ZYWGtlTnVraHU0cGRuT21nL21E?= =?utf-8?B?WXIwbzEzNzVhTjlmc3pIZWo0VGY4SnpTbnlRMFo0dnp0U3JDOXhjV0J1dFFY?= =?utf-8?B?T2NSUDhQWi9wUnVaU2RKN1ZDTTJ6eTY5cisyb2lvL3EydG1wSGlWaEw5VHl6?= =?utf-8?Q?Yjt7v6p9jBaRaBWu+CJQXQktLX04JyYrQH5p56V?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c50cee7-af5e-4a1e-3e11-08d8fa2af4f4 X-MS-Exchange-CrossTenant-AuthSource: BN6PR10MB1748.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 01:09:28.5349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QEzltzaKCOjijCuJycE8EL2uOyDSeCWLUIfOMIdMNRaJgSTwzazXQJ/5ys0zVyu3B/fcpVBN9kcT/wwqAAkpDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4902 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9947 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104080002 X-Proofpoint-GUID: AANwzVQGeV3EpJjK79je-ylkbiIUBi6f X-Proofpoint-ORIG-GUID: AANwzVQGeV3EpJjK79je-ylkbiIUBi6f X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9947 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104080002 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 01:09:34 -0000 On 4/1/2021 9:56 AM, Tom Tromey wrote: >>> Added function fetch_tid_type which calls get_tid_type and will set up >>> the type, associated with a tid, if it is not read in yet. Also implement >>> function read_forward_type which handles the CTF_K_FORWARD kind. >>> Expanded gdb.base/ctf-ptype.exp to add cases with forward references. > Thanks for the patch. > >>> + if (name != NULL && strlen (name.get() ) != 0) > A nit here -- "get() )" should be "get ())" Got rid of the space and pushed to main. Thank you. > > This is ok with this change. > > Tom