Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Simon Marchi (Code Review)]

Hello Andrew Burgess, Tom de Vries, 

I'd like you to reexamine a change. Please visit

    https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41

to look at the new patch set (#5).

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................

gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout

Commit 580f1034 ("Increase timeout in
gdb.mi/list-thread-groups-available.exp") changed
gdb.mi/list-thread-groups-available.exp to significantly increase the
timeout, which was necessary for when running with make check-read1.

Pedro suggested a better alternative, which is to use gdb_test_multiple
and consume one entry at a time.  This patch does that.

gdb/testsuite/ChangeLog:

	* gdb.mi/list-thread-groups-available.exp: Read entries one by
	one instead of increasing timeout.

Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
---
M gdb/testsuite/gdb.mi/list-thread-groups-available.exp
1 file changed, 20 insertions(+), 9 deletions(-)


  git pull ssh://gnutoolchain-gerrit.osci.io:29418/binutils-gdb refs/changes/41/41/5
-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: newpatchset

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Simon Marchi (Code Review)]

Simon Marchi has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................


Patch Set 4:

> I added the prompt_regexp parameter to gdb_test_multiple to allow: gdb_test_multiple <command> <message> <user-code> $mi_gdb_prompt.
> 
> Have you tried that?

No, I hadn't thought about that.  I just tried and it works, so I've updated to patch to do that.  Thanks for the tip.


-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 15:51:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Tom de Vries (Code Review)]

Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

LGTM, there's one nit that optionally could be fixed.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
PS5, Line 74: 	pass $test
You could do pass $gdb_test_name and get rid of the test variable.



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Simon Marchi (Code Review)]

Simon Marchi has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5: Code-Review+1
> 
> (1 comment)
> 
> LGTM, there's one nit that optionally could be fixed.

Oh right, I have seen this patch pass by but didn't think of using it there.  Fixed.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
PS5, Line 74: 	pass $test
> You could do pass $gdb_test_name and get rid of the test variable.
Done



-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:06:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: comment

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Simon Marchi (Code Review)]

Hello Andrew Burgess, Tom de Vries, 

I'd like you to reexamine a change. Please visit

    https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41

to look at the new patch set (#6).

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................

gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout

Commit 580f1034 ("Increase timeout in
gdb.mi/list-thread-groups-available.exp") changed
gdb.mi/list-thread-groups-available.exp to significantly increase the
timeout, which was necessary for when running with make check-read1.

Pedro suggested a better alternative, which is to use gdb_test_multiple
and consume one entry at a time.  This patch does that.

gdb/testsuite/ChangeLog:

	* gdb.mi/list-thread-groups-available.exp: Read entries one by
	one instead of increasing timeout.

Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
---
M gdb/testsuite/gdb.mi/list-thread-groups-available.exp
1 file changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gnutoolchain-gerrit.osci.io:29418/binutils-gdb refs/changes/41/41/6
-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: newpatchset

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Tom de Vries (Code Review)]

Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:08:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Sourceware to Gerrit sync (Code Review)]

Sourceware to Gerrit sync has uploaded a new patch set (#7) to the change originally created by Simon Marchi. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................

gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout

Commit 580f1034 ("Increase timeout in
gdb.mi/list-thread-groups-available.exp") changed
gdb.mi/list-thread-groups-available.exp to significantly increase the
timeout, which was necessary for when running with make check-read1.

Pedro suggested a better alternative, which is to use gdb_test_multiple
and consume one entry at a time.  This patch does that.

gdb/testsuite/ChangeLog:

	* gdb.mi/list-thread-groups-available.exp: Read entries one by
	one instead of increasing timeout.

Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.mi/list-thread-groups-available.exp
2 files changed, 23 insertions(+), 9 deletions(-)


  git pull ssh://gnutoolchain-gerrit.osci.io:29418/binutils-gdb refs/changes/41/41/7
-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 7
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: newpatchset

Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...

[Sourceware to Gerrit sync (Code Review)]

Sourceware to Gerrit sync has submitted this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )

Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................

gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout

Commit 580f1034 ("Increase timeout in
gdb.mi/list-thread-groups-available.exp") changed
gdb.mi/list-thread-groups-available.exp to significantly increase the
timeout, which was necessary for when running with make check-read1.

Pedro suggested a better alternative, which is to use gdb_test_multiple
and consume one entry at a time.  This patch does that.

gdb/testsuite/ChangeLog:

	* gdb.mi/list-thread-groups-available.exp: Read entries one by
	one instead of increasing timeout.

Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.mi/list-thread-groups-available.exp
2 files changed, 23 insertions(+), 9 deletions(-)



diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ba72489..ce6e0f2 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-14  Simon Marchi <simon.marchi@polymtl.ca>
+
+	* gdb.mi/list-thread-groups-available.exp: Read entries one by
+	one instead of increasing timeout.
+
 2019-10-13  Tom de Vries  <tdevries@suse.de>
 
 	PR record/25038
diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
index ab5c716..3a7517f 100644
--- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
+++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
@@ -54,15 +54,24 @@
 # List all available processes.
 set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}"
 
-# Increase the timeout: when running with `make check-read1`, this can take
-# a bit of time, as there is a lot of output generated, hence a lot of read
-# syscalls.
-with_read1_timeout_factor 10 {
-    mi_gdb_test \
-	"-list-thread-groups --available" \
-	"\\^done,groups=\\\[${process_entry_re}(,$process_entry_re)*\\\]" \
-	"list available thread groups"
-}
+# The list can be long, so read entries one by one to avoid hitting the
+# timeout (especially when running with check-read1).
+gdb_test_multiple "-list-thread-groups --available" "list available thread groups" {
+    -re "\\^done,groups=\\\[" {
+	# The beginning of the response.
+	exp_continue
+    }
+
+    -re "${process_entry_re}," {
+	# All entries except the last one.
+	exp_continue
+    }
+
+    -re "${process_entry_re}\\\]\r\n${mi_gdb_prompt}" {
+	# The last entry.
+	pass $gdb_test_name
+    }
+} $mi_gdb_prompt
 
 # List specific processes, make sure there are two entries.
 set spawn_id_1 [remote_spawn target $binfile]

-- 
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 7
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-MessageType: merged

Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)

[Tom Tromey]

Hi.  I've been looking at the gerrit review email.
I'd like to suggest a way it could be improved.

Consider this review:

Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:

Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
Tom> PS5, Line 74: 	pass $test
Tom> You could do pass $gdb_test_name and get rid of the test variable.

This would be a lot better if the email included more of the patch
context.  As is, it's not very readable on the list.  While I do want to
use gerrit, at the same time I think it would be nice to be able to
following the mailing list and get a reasonably complete idea of what's
going on.

Tom

Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)

[Simon Marchi]

On 2019-10-14 2:06 p.m., Tom Tromey wrote:
> Hi.  I've been looking at the gerrit review email.
> I'd like to suggest a way it could be improved.
> 
> Consider this review:
> 
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
> Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
> 
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
> Tom> PS5, Line 74: 	pass $test
> Tom> You could do pass $gdb_test_name and get rid of the test variable.
> 
> This would be a lot better if the email included more of the patch
> context.  As is, it's not very readable on the list.  While I do want to
> use gerrit, at the same time I think it would be nice to be able to
> following the mailing list and get a reasonably complete idea of what's
> going on.
> 
> Tom

I'll take a look if it's possible to modify the templates to do so.

Simon

Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)

[Simon Marchi]

On 2019-10-14 8:44 p.m., Simon Marchi wrote:
> On 2019-10-14 2:06 p.m., Tom Tromey wrote:
>> Hi.  I've been looking at the gerrit review email.
>> I'd like to suggest a way it could be improved.
>>
>> Consider this review:
>>
>> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
>> Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
>>
>> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
>> Tom> PS5, Line 74: 	pass $test
>> Tom> You could do pass $gdb_test_name and get rid of the test variable.
>>
>> This would be a lot better if the email included more of the patch
>> context.  As is, it's not very readable on the list.  While I do want to
>> use gerrit, at the same time I think it would be nice to be able to
>> following the mailing list and get a reasonably complete idea of what's
>> going on.
>>
>> Tom
> 
> I'll take a look if it's possible to modify the templates to do so.

It doesn't seem to be possible out of the box.  The template can only work
with the data passed by Gerrit.  For a line comment, we only get the single
line it refers to:

  https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328

Simon

Re: Gerrit request

[Tom Tromey]

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Tom> This would be a lot better if the email included more of the patch
Tom> context.

Simon> It doesn't seem to be possible out of the box.  The template can only work
Simon> with the data passed by Gerrit.  For a line comment, we only get the single
Simon> line it refers to:

Simon>   https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328

That's unfortunate.  For me this makes the patch reviews pretty
unreadable on the list.

Maybe a gerrit feature request is in order.

Tom

Re: Gerrit request

[Sergio Durigan Junior]

On Tuesday, October 15 2019, Tom Tromey wrote:

>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Tom> This would be a lot better if the email included more of the patch
> Tom> context.
>
> Simon> It doesn't seem to be possible out of the box.  The template can only work
> Simon> with the data passed by Gerrit.  For a line comment, we only get the single
> Simon> line it refers to:
>
> Simon>   https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328
>
> That's unfortunate.  For me this makes the patch reviews pretty
> unreadable on the list.
>
> Maybe a gerrit feature request is in order.

I had found this limitation yesterday before Simon's reply, and I was
looking into opening a bug report/feature request against gerrit, but
they use Chromium's bugzilla, which requires a Google account to post
things, so that's a no-no for me.

Maybe someone else can do that.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Re: Gerrit request

[Simon Marchi]

On 2019-10-15 1:12 p.m., Sergio Durigan Junior wrote:
> On Tuesday, October 15 2019, Tom Tromey wrote:
> 
>>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>>
>> Tom> This would be a lot better if the email included more of the patch
>> Tom> context.
>>
>> Simon> It doesn't seem to be possible out of the box.  The template can only work
>> Simon> with the data passed by Gerrit.  For a line comment, we only get the single
>> Simon> line it refers to:
>>
>> Simon>   https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328
>>
>> That's unfortunate.  For me this makes the patch reviews pretty
>> unreadable on the list.
>>
>> Maybe a gerrit feature request is in order.
> 
> I had found this limitation yesterday before Simon's reply, and I was
> looking into opening a bug report/feature request against gerrit, but
> they use Chromium's bugzilla, which requires a Google account to post
> things, so that's a no-no for me.
> 
> Maybe someone else can do that.

Well, I built Gerrit locally and was able to make a change to allow displaying a fixed
number of lines before the line the comment is attached to.  I'm just not sure I am
ready to go through the patch submission process, as it probably involves adding some
configuration option, documentation, testing, etc.  Just like when submitting a patch to
GDB :).

But I can at least open a feature request describing what I have prototyped.  I'll try to
do that later today.

Simon