From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by sourceware.org (Postfix) with ESMTPS id 7B1A13858000 for ; Mon, 1 Nov 2021 16:00:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B1A13858000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOnmhiaUOQ3nHAV34M8YTEWYFWK27PIqcoNc6g9RxueeaTqOX/N2I62EsWpydDpQ+JjBE5Mod5eHZQ6MkUXyCV+fHcWKynDvZvhKg4tLFd6pMMUwz18PzQrcwOniX6s4Y5F3QyhH0jHgouABF2zhddqJv+Tg9eF5yRwDG5SxBBzAcH3orvuys1BrKY8mkhl0k/bE4u72hNcLh3bUiIkDKkqsx5BLTTIlG7bQXL6tYuUs04jHTAAbq/AxYGKAyAWF3xaRkvljmvKR/AQIMJitI8uh5U2SZi+PEpfEoIK3ihnB76+BLkr9v/PI97JeX/dWfvwKeVCi1Iwdv7FSkhTS4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y87bK2uRJLYV8Hpvc0hTtOo4CANFFmRoICP5R1H3zcA=; b=afdN5go/ZMEDHBl4OKyA4WkhpOFZ4EBRKzOZTmThYXDYF678+oturEJKc6UG4mfUW9PBq1HwGxnZE9b9NTx2ctOQaQd0Q5Ik2yHXSxR5sETIB7fKINhcrEI0SCD7fLcbxbg2AJS95NqNLoj7Kh0X2Qu6NI2+hiioc404NcaTWSszKDA5ddlaqTyxo0/40grCiaMYLMqr9HCcZEyk7lJZoR9HjJ8p+LJsbLCGn2ESn0aKBl1x+JF3eVwkkr1QrPvRQqivo4VYJaUJBk85maK1T9Z7TMxlWG/YXZY9WWH1C4o8r7aYqL9xAALUsQbqCLRo13fUA5KB0RWebObv1H9aPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5353.namprd12.prod.outlook.com (2603:10b6:408:102::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 16:00:07 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 16:00:07 +0000 Subject: Re: [PATCH v3 04/28] Add to_location method to DWARF entry classes To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-5-zoran.zaric@amd.com> <20211022212054.jzoa2vhrdq4pl2yi@ubuntu.lan> From: Zoran Zaric Message-ID: Date: Mon, 1 Nov 2021 16:00:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20211022212054.jzoa2vhrdq4pl2yi@ubuntu.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0061.eurprd04.prod.outlook.com (2603:10a6:20b:48b::15) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 Received: from [IPv6:2a00:23c7:1093:6301:28e8:5ece:e307:7c2] (2a00:23c7:1093:6301:28e8:5ece:e307:7c2) by AS9PR04CA0061.eurprd04.prod.outlook.com (2603:10a6:20b:48b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Mon, 1 Nov 2021 16:00:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80bc2068-dc9e-41e2-11e1-08d99d50ac9a X-MS-TrafficTypeDiagnostic: BN9PR12MB5353: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A6DwHW8NtLMoedvYvWT3+rR+PEGGQpVCc5J0XV2gf9UCvGOUsX4paY70/9QFUYrbQU2thS88twD7myXx1P4CVyS+EEwftnoGevT1RskOnutvROx+hEYCueztNqU5DLnoWj8AlUvO590JIotMyFt7YlsvjCdMZ8gBRQJqmBywASzcZBymsZbj7ppT4KDdGoOyZEXYH3LfuHF5yOrOLYEBYBWJgSA6dETwIn/SqbPYMjilZSHITqzfjka10FKC0PY7wn/YKAjwAy2EIfjb8R9aVltSFZKeZBmUWEApwwHapLNcdjrSWdwnZKbcw6Zk8RTQ15Na7P08+GqztaDF018RDoMHc9971AhpvftbhmHMASlT9pp5c7GZWgaYI17eYRw7+QJLYJzFR9UbONxDRv0bHeYMtdHiRcAehYFKSMWBwL1T6hv2LKgqEUNce2/RyK7wb6sfHP3VZcvwfyPGGYuIBQV+dxVirkFQWzKAc8wHOjPxl0EcaEg5SW1YiAl9YP8P7ml5uCqOxm4l29iSxZf7x+uT80CY3GsXItgUmVuYSxjBBFQh7ocv+L98siClkf7r0RxcweMnfdEMBEFbitKZFC8PKmovLPlLqQGOCSK6ONMJe33xpAVXkbh+QygqA+njbV7bc5x0MJHQogNv614EyXthGfOm/wVfRmSJECGgAej2FGgT+E+zvalv+y8AvCioBRcBCd1nmZfrtMZQoiDHPdfgFcm8wVRP9CvEejnIsAzNdTfQNlq0i+fJguvc9TeM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2616005)(66476007)(2906002)(508600001)(4326008)(31696002)(66556008)(66946007)(186003)(316002)(6666004)(5660300002)(6486002)(6916009)(44832011)(8936002)(36756003)(38100700002)(86362001)(31686004)(53546011)(8676002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpiQVhaQmNCMlhuTHZiRGFhem1CVmhTWlV6a3l0V3lsNDh0Z1FmTDcwS3FM?= =?utf-8?B?aHdUV1dyMUZQQ2FTY2Q2YjhrZDNCaEdsNzROMmVwODVNdWROOWExemNuL3pH?= =?utf-8?B?R0RPdjVYcG11dlpsT1NlRFd2QmlLb1pCbVJpUi95V3EvdHhVenVLRWE2NTdz?= =?utf-8?B?Y2tML25JUFlLeEgySWNFT1RvZUZxZEg0aWJLMXZGbzZJQStvUGxoYjJWM2gz?= =?utf-8?B?NmlTaC91THNma2YyTHVOWUpoeW5JOEZKSlJQa0ZwWmNjQjQvU1UraUQ5NXlw?= =?utf-8?B?OWpqS3IzWWoxSVdvelF4eS9xRGppcEhGMWkzMWVVdHZlQTE3TkkxRlRtQjVk?= =?utf-8?B?SDdvVlNQZHJ6VjVDdmNneEhneVMrMjhxRlB0aXY4a3ozbXJBdWdDVk9NdFlK?= =?utf-8?B?ckFMc3hDMFJMeEVvNFZ4dFFMd1N1RnNnZTlXOUkzQlNSbUttOWQveTVnUm55?= =?utf-8?B?aWl0RytKTG9Vbm5JaC81dExhTTJCMWVnMlVmTFhCVUVoZTQwVzRCNkRWUHpW?= =?utf-8?B?NDZMUURML3ErL2dGdUcwWUpzb1RnUWE4ZEFZSVkvZXB3Ukxkd0lhZzhZMURM?= =?utf-8?B?WlJ3MVc1dThUc3o2RVlyOHhuZXBaWUN3eEx3UVhPNWVENGJOUE1EMjRQU0NQ?= =?utf-8?B?T0hUdlRhQXNVdVpEQ1RUWjNYN1ZKR2dtcUJhV2lpZFVxUFpYRXZMbktBdWx1?= =?utf-8?B?cHpMMW1mWlg1SytNaTgyU3RySm9VZUpaYWhRMnRmd251azhHWmxVMkN2UDRk?= =?utf-8?B?MlpJdnhwZGRDZGFRcC9EMHdFOTlCNXltaDVmNWhvSjBpbzNHMDA1TUZlNVlJ?= =?utf-8?B?ajRZM2xwSWtGWEdXQUVxS0dpT2ozVUtuRjZ2Q2xjaU9YSGJaU0s1b0VSNjdN?= =?utf-8?B?ZGVIN3RRQnBjTGpQT0hJR2VkeTFSZTJhKzNTeDFrTFAzYS9Pa0hXSHVGQkRY?= =?utf-8?B?ak5HRGlrS2grMGZ4bmo5NlJ0eVJKUlc0RXo0MUZmL2F2N3lHV3drZVhRMDBa?= =?utf-8?B?bFhSanBPQ05SNEh4MFdmRkpFMHRHWUdxdlZ5MktNalZyVDNNeWszNUVJR09G?= =?utf-8?B?VjNLTUtlN2lKM2ZkVkJqdDNFUWNlc1pVSXlPYlBac1ZhTzRhN2U5UHo4REQv?= =?utf-8?B?VWVIRlU0TEtzcXZmNFVRUytMTlUxYWsvNUFWalE1ck9VQjcvU0I2WmpxSjRJ?= =?utf-8?B?NG5PNXhoVGV4TDYyZkk5Q1lBeHVQZTJJR2JLeHRwcXJ0VXFsSlZlSXBnRUpX?= =?utf-8?B?a3Q4c1lHQi9pSzgwZ0xhNDE3TTZRa0ozODlwN3I1Y1QrL0czc0Rxb0xoZnJu?= =?utf-8?B?NGxjcnFiV2hETmNVZ3J3UWV0eklSOXEvL3I1V0U0ck1TZUEvbDFFZzBGNXhQ?= =?utf-8?B?L2gvR3phQnl2ZnVwZjZCenFNcmhqNUdHdWJ1RUg2MUI2Y0o4Vk1LYVptdUVz?= =?utf-8?B?RjE4S0JoU0g2Qm5aZ1EwVUV6Sm1sMnpEVjZyTW54bkxzU0dCQkR4eTlCaFJ3?= =?utf-8?B?QWlqdUNYOFgyTUNDTmxZVlpCNVQ4YitzM0xnQitiZ3NlRDJOMnRXSW5BYk9h?= =?utf-8?B?UkJqak9ZRzdBZUh4VE5xZU9HV2M0dXljZlBIS2gvVDBzWEF5SVFGYlk0ZG5J?= =?utf-8?B?Mk9XYmFjbENCdkI5bTdNekFKZUxaVG10TVRFRlVjVy9wWFNPM1laeXRFTDVX?= =?utf-8?B?ZmRsSEJnUjkwTmlPQTQ4ZTFxTnc1N0k2eDdKY0tLaXEwT2lTSTVGaDZTdmM0?= =?utf-8?B?cjB6c04wNTdBb2tKZXJ5NXBXZXBEK2s4TXBDOGJiU3lPK2lWeTlPWHQwZk9C?= =?utf-8?B?b3Y5eW54V2VvcFhwSHhKd3dUUlZoN2RaNFN6b3E1Uk5RSS9mOWkzbFB0TDFF?= =?utf-8?B?cGJZRVFwcVNmbTAxMGxsQTh1RmtXK0V3NVJCdUFnaEpGZFdsVCtpcUVmZ2Ew?= =?utf-8?B?SXJBNEhXYTljaW5EdkFUTkJZZjlLbkF0enlGaElYUXFDZjJucUYzUTBkYWlQ?= =?utf-8?B?dTJnZVp2T0hsRC9zcmRGMWVaOG80N1NFYStGUDR6MVZTbDNkeFJDazQ5RkJI?= =?utf-8?B?djV6aE5VYXhvSmt3STlDMXRuUFdUZEZ1TDNsa3ZXZjhwOWQ0WlpFVkZBR1gw?= =?utf-8?B?TGtSalpkaDhPTTBLL1NQYTVVWEVYbm9BVlh6WnJGc002d1c4cWJwSDUvYWtw?= =?utf-8?B?MzFPRnFaS0NSN3BsM2VqZCt0S3pXYUgwdEwxVm9qdjV6WGpsRGxSZTQ0N1ZU?= =?utf-8?Q?wve7JybFjC+E1+5ZUhJCR1ZWfozFzHE883nXzLFVn0=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80bc2068-dc9e-41e2-11e1-08d99d50ac9a X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 16:00:07.0907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ziy3Ped31EP/zoTHVvbfpqhQA7hx7N/elUk8aFxm2WfkxCjUtchB4o4YmdeXK/qDGLXFpqtdOCUU6Xdy0tXb2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5353 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 16:00:11 -0000 Thank you for reviewing my patch. On 10/22/21 10:21 PM, Lancelot SIX wrote: > [CAUTION: External Email] > > Hi, > > As for the previous patch, I have included comments and questions > below. > > On Thu, Oct 14, 2021 at 10:32:11AM +0100, Zoran Zaric via Gdb-patches wrote: >> From: Zoran Zaric >> >> DWARF standard already contains an implicit conversion between location >> description and a DWARF value. In the DWARF 5 version, one place >> where this can happen is at the very end of the evaluation where a >> client decides if the result is expected to be in a form of a value or >> a location description (as_lval argument of the new evaluation method). >> >> By allowing any location description to be on the DWARF stack, these >> implicit conversions are expected on per operation basis which means >> that the new DWARF entry classes need to have a support for those. >> >> This patch adds a conversion method from any DWARF entry object into a >> location description object. > > Reading this, I kind of expect to find the 'to_location' method to be > defined in dwarf_entry, but it is only created for dwarf_value (the only > non-dwarf_location-based class). > > Reading a bit ahead, I looks like the to_location free function that will > be introduced in patch 16 of this series ('Change DWARF stack to use new > dwarf_entry classes') could fit the description. After having a look at > this function, it looks like it could have been included in this patch > instead. Was it intended be be included here and somehow slipped in > another patch? I will change the patch notes to say the the method was added to dwarf_value class and leave the description of the free function to the patch where I actually add it. I can't really add the free function at this point in the series because it is still not used anywhere and the gdb build system will complain. Zoran