public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix compilation using mingw.org's MinGW
Date: Tue, 30 Apr 2019 13:10:00 -0000	[thread overview]
Message-ID: <b9878710-1971-4221-3cbf-21cc108be309@redhat.com> (raw)
In-Reply-To: <b8cd7a4b-a582-3073-6bde-9b0a952bb22e@redhat.com>

On 4/30/19 1:56 PM, Pedro Alves wrote:
> Sure, LGTM.
> 
> A few remarks:
> 
>  - The override in _WIN32_WINNT is no longer necessary.  It could
>    be removed at the same time.

I meant the _WIN32_WINNT override in common/netstuff.c.

I see now that there are more of those in other files too.

Thanks,
Pedro Alves

  parent reply	other threads:[~2019-04-30 13:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 15:36 Eli Zaretskii
2019-04-18 17:01 ` Kevin Buettner
2019-04-18 18:54   ` Eli Zaretskii
2019-04-18 20:38     ` Kevin Buettner
2019-04-19  6:19       ` Eli Zaretskii
2019-04-18 17:20 ` Pedro Alves
2019-04-18 17:22   ` Pedro Alves
2019-04-18 18:57     ` Eli Zaretskii
2019-04-19 10:51       ` Pedro Alves
2019-04-19 11:23         ` Eli Zaretskii
2019-04-19 11:33           ` Pedro Alves
2019-04-28 14:33             ` Eli Zaretskii
2019-04-30 12:56               ` Pedro Alves
2019-04-30 13:06                 ` LRN
2019-04-30 15:25                   ` Eli Zaretskii
2019-04-30 17:04                     ` Pedro Alves
2019-04-30 17:17                       ` Eli Zaretskii
2019-04-30 17:26                         ` Pedro Alves
2019-04-30 17:40                           ` Eli Zaretskii
2019-04-30 17:58                             ` Pedro Alves
2019-04-30 18:34                               ` Eli Zaretskii
2019-04-30 18:38                                 ` Pedro Alves
2019-04-30 17:50                     ` LRN
2019-04-30 13:10                 ` Pedro Alves [this message]
2019-04-30 15:23                   ` Eli Zaretskii
2019-04-30 16:31                     ` Pedro Alves
2019-05-03  8:04                       ` Eli Zaretskii
2019-05-03  8:26                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9878710-1971-4221-3cbf-21cc108be309@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).