public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v4] [gdb/testsuite] update analyze-racy-logs.py to python3
@ 2021-10-01 20:59 Bruno Larsen
  2021-10-02  1:32 ` Simon Marchi
  0 siblings, 1 reply; 3+ messages in thread
From: Bruno Larsen @ 2021-10-01 20:59 UTC (permalink / raw)
  To: gdb-patches

Since python 2 is no longer supported on most distributions, update the
script to run under python while while still being runnable under
python2.
---
 gdb/testsuite/analyze-racy-logs.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gdb/testsuite/analyze-racy-logs.py b/gdb/testsuite/analyze-racy-logs.py
index 604a272831c..4724e1bdbfc 100755
--- a/gdb/testsuite/analyze-racy-logs.py
+++ b/gdb/testsuite/analyze-racy-logs.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 # Copyright (C) 2016-2021 Free Software Foundation, Inc.
 #
@@ -145,7 +145,7 @@ def identify_racy_tests():
     # to be ignored.  For example, tests both in the PASS and KFAIL
     # states should not be considered racy.
     ignored_tests = set()
-    for s1, s2 in ignore_relations.iteritems():
+    for s1, s2 in ignore_relations.items():
         try:
             ignored_tests |= all_tests[s1] & all_tests[s2]
         except:
@@ -159,16 +159,16 @@ def identify_racy_tests():
     racy_tests = racy_tests - ignored_tests
 
     # Print the header.
-    print "\t\t=== gdb racy tests ===\n"
+    print("\t\t=== gdb racy tests ===\n")
 
     # Print each test.
     for line in sorted(racy_tests):
-        print line
+        print(line)
 
     # Print the summary.
-    print "\n"
-    print "\t\t=== gdb Summary ===\n"
-    print "# of racy tests:\t\t%d" % len(racy_tests)
+    print("\n")
+    print("\t\t=== gdb Summary ===\n")
+    print("# of racy tests:\t\t%d" % len(racy_tests))
 
 
 if __name__ == "__main__":
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] [gdb/testsuite] update analyze-racy-logs.py to python3
  2021-10-01 20:59 [PATCH v4] [gdb/testsuite] update analyze-racy-logs.py to python3 Bruno Larsen
@ 2021-10-02  1:32 ` Simon Marchi
  2021-10-04 12:58   ` Bruno Larsen
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2021-10-02  1:32 UTC (permalink / raw)
  To: Bruno Larsen, gdb-patches

On 2021-10-01 16:59, Bruno Larsen via Gdb-patches wrote:
> Since python 2 is no longer supported on most distributions, update the
> script to run under python while while still being runnable under
> python2.

This is ok.  Do you have a Sourceware account to push the patch?  If
not, would you like one (useful if you intend to send patches
regularly), or would you like me to push the patch for you?

Simon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] [gdb/testsuite] update analyze-racy-logs.py to python3
  2021-10-02  1:32 ` Simon Marchi
@ 2021-10-04 12:58   ` Bruno Larsen
  0 siblings, 0 replies; 3+ messages in thread
From: Bruno Larsen @ 2021-10-04 12:58 UTC (permalink / raw)
  To: Simon Marchi, gdb-patches

On 10/1/21 10:32 PM, Simon Marchi wrote:
> On 2021-10-01 16:59, Bruno Larsen via Gdb-patches wrote:
>> Since python 2 is no longer supported on most distributions, update the
>> script to run under python while while still being runnable under
>> python2.
> 
> This is ok.  Do you have a Sourceware account to push the patch?  If
> not, would you like one (useful if you intend to send patches
> regularly), or would you like me to push the patch for you?
> 
> Simon
> 

Thank you for the review! I've pushed the patch

-- 
Cheers!
Bruno Larsen


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-04 12:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 20:59 [PATCH v4] [gdb/testsuite] update analyze-racy-logs.py to python3 Bruno Larsen
2021-10-02  1:32 ` Simon Marchi
2021-10-04 12:58   ` Bruno Larsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).