From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CDA4A393825A for ; Wed, 5 Jun 2024 13:32:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDA4A393825A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDA4A393825A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717594380; cv=none; b=KvN93MN811J4osfp6Y6hGuYozu1wvNIZISbfFHjn6gPn7tk98uJsFXlpz+WExw6j7CCcVoIR0oxnNzANme8ncOWfWufbythu4GDFR5Eie2GXctyC5p7jWcUSnbcOshquyn/S78VmeQ3u54VgtnxxRRygw2ASausfC2kIy6CD5tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717594380; c=relaxed/simple; bh=i/c9W0L5E3tvw+g7zZDcWP5fvYOQfZ50bexHHOpyk7Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=EojzkxBsnfLlnYrSkRj0QATw2MHX7/VtDC47FMBrH/F+oGEJtsXR4Zl116DYv+JfJqcssiH2S/cjgIb6z8KoMuLfffin3YaZfqapIditCYDHz5MQSjjIyOsyTw8XSHgpLm5TLRMg9F7WF4L5KOml0WAp4A7wngwZcwe+Idbocvs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717594376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jhr/n18zoy65Ncj2JxZp+ck1tQsszZyg8xG0MPCTtIk=; b=ZQVrhZjNjD30oHjMP1Ser1TEAVwpdvUSzfn6gRcWMPoNwQDcinK4mV8f85+S1oaulKmVmd h1yi4Q8skhrF7t+1/6T/444mJyHuIo1Er6W5V2B2px1Hf4x+Ml56Y2yIjk+H6JhQwTUj+s wG/iitrl7VX2eNKRChIPzpnBPFTgx/4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-mEG_E8P2OBuYFkwNcFHMZg-1; Wed, 05 Jun 2024 09:32:54 -0400 X-MC-Unique: mEG_E8P2OBuYFkwNcFHMZg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35dcb574515so1392060f8f.0 for ; Wed, 05 Jun 2024 06:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717594371; x=1718199171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jhr/n18zoy65Ncj2JxZp+ck1tQsszZyg8xG0MPCTtIk=; b=LbiaeVc4jYqAv9neNjq/XCo6QdmKGVgZrXZpxzAb+k56U/6r8yEvBpS7IHbZkcPWW4 Gx+h0XGBZOt4/bbu/ZEDTBGQp0HXSZWP4/7P6a6+eVmKiHVuYV5DfwpeGUDGA+JWcMgm phFIedUx+7WBjzf6Hx6b7grb6k0zQxBnkLwBAUF88V4PY3K8VEBJKwvbBtssGFTSfAcA roVl/LvzOzrZaxyybR6LkC+HMDq4Bkvw5nj8ki4KJR9rbrpJEanX+Vr2/EK717FNeD3v OTMhCcd1evLq2AGVca4m08GZYh+jUPHTmxnd4nw9dHeC5qrY6l/RE40cZqKA/m43podp zCJQ== X-Gm-Message-State: AOJu0YzMNnu+kr4kVlb6Th5GchwTalxFFPb/YdZn5KR6abLMV07KIXby kJMGymekhm9yzVq1cOiO9MUx1f/nPmVh3sS22ATWAKEfLCFvVuyrl7Lcb7jwzfVJYG9aTc1TGra 7OXn4GGBY8IOs7B8h3+xuVXXBFLEftgU31Zg/8uKm6bSDyIywtBeaxiU2qd+dudZ+SAkxN1eBLU jxUwLnpsHXFBUaQ00BY3GcjOOfuKoVYdVhD/HX6szqnMA= X-Received: by 2002:a5d:4645:0:b0:35d:ca3b:4d11 with SMTP id ffacd0b85a97d-35e8ef97043mr1859622f8f.61.1717594371187; Wed, 05 Jun 2024 06:32:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERj1PX0V7vqDFIli6/Y3AGZzLvns6Fl+XVFbPgEflA3rGfkgjz3Q5+IwCfABN+wYGMtR7ctw== X-Received: by 2002:a5d:4645:0:b0:35d:ca3b:4d11 with SMTP id ffacd0b85a97d-35e8ef97043mr1859597f8f.61.1717594370603; Wed, 05 Jun 2024 06:32:50 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd0649fb5sm14491377f8f.94.2024.06.05.06.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 06:32:50 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv11 3/9] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Wed, 5 Jun 2024 14:32:37 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 6f9750e19fa..410d443bac4 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -283,9 +283,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -300,10 +297,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12406,17 +12404,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4