From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7978 invoked by alias); 20 Feb 2018 16:49:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7965 invoked by uid 89); 20 Feb 2018 16:49:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 16:49:34 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 00E498AA03; Tue, 20 Feb 2018 16:49:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52E381006ECD; Tue, 20 Feb 2018 16:49:32 +0000 (UTC) Subject: Re: [PATCH] dwarf: Make sect_offset 64-bits To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <1514692098-8054-1-git-send-email-simon.marchi@ericsson.com> <0694b84f-7fef-5373-2cb3-87f6b8fd56b7@polymtl.ca> <09806ce5-3e85-dacc-cf3e-22660fab90b8@ericsson.com> From: Pedro Alves Message-ID: Date: Tue, 20 Feb 2018 16:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <09806ce5-3e85-dacc-cf3e-22660fab90b8@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00268.txt.bz2 On 02/20/2018 04:38 PM, Simon Marchi wrote: > On 2018-01-28 12:26 PM, Simon Marchi wrote: >> Does anybody have an opinion about this? It would be nice to unbreak >> the "default" build with clang (i.e. without passing special -Wno-error= >> flags). >> >> Here's a version rebased on today's master. > > Ping. > Does this change the type of any field of the structures that form the indexes? I.e., does it affect binary compatibility there? I.e., can you save a gdb index with pre-patch gdb, and load it back in post-patch gdb. Likewise viceversa. Also DWARF5 indexes. Also, just for the record, can we assume that this doesn't increase memory usage considerably when debugging bigger programs? I assume that this will create some padding holes in some structures and that we can probably win back the memory by just changing order of some fields for better packing. Offhand, I know about code in dwarf2read.c that assumes that offset_type is 32-bit for both of the reasons above -- memory usage (e.g., struct name_component), and also as type used in indexes. I'm not seeing anything for sect_offset, but can you double check? Thanks, Pedro Alves