From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25201 invoked by alias); 21 Sep 2016 16:43:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25190 invoked by uid 89); 21 Sep 2016 16:43:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:813 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 16:43:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25DEEC04B949; Wed, 21 Sep 2016 16:43:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8LGhmnm014013; Wed, 21 Sep 2016 12:43:49 -0400 Subject: Re: [RFA 1/2] PR gdb/20604 - fix "quit" when an invalid expression is used To: Tom Tromey References: <1473893962-12420-1-git-send-email-tom@tromey.com> <89cb37c2-642c-f236-ddd3-ccabad4f800c@redhat.com> <87vaxqyyvg.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 21 Sep 2016 17:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87vaxqyyvg.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00260.txt.bz2 On 09/20/2016 11:45 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Hi Tom, the gdb code looks fine. Some comments on the test. > > Pedro> Could you try the new test with --host_board=local-remote-host.exp? > Pedro> That should cover at least remote ssh testing, which is what > Pedro> most people use nowadays, anyway. I'd be happy with that. > > I tried this today and it worked for me. > >>> +close $gdb_spawn_id > > Pedro> Maybe just calling clear_gdb_spawn_id at the end is all that's > Pedro> necessary? > > Seems like a good idea, I made this change locally. > OK, thanks. Fell free to push. We'll do something about it if it causes problems on real remote hosts. Thanks, Pedro Alves