public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
	Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 2/2] gdb: add nullptr check to cooked_index_functions::dump
Date: Tue, 31 Jan 2023 13:22:15 -0500	[thread overview]
Message-ID: <ba4d1319-a9d0-9121-8c07-8d854ccbbaa5@simark.ca> (raw)
In-Reply-To: <87wn52li84.fsf@tromey.com>

On 1/31/23 12:35, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Print the "Cooked index in use" message after the nullptr check, such
> Simon> that if the cooked index failed to build, that message is not printed.
> 
> Thank you.  This looks good to me.
> 
> Tom

Thanks, pushed both patches.

Simon

  reply	other threads:[~2023-01-31 18:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 15:57 [PATCH 1/2] gdbsupport: allow passing nullptr to checked_static_cast Simon Marchi
2023-01-31 15:57 ` [PATCH 2/2] gdb: add nullptr check to cooked_index_functions::dump Simon Marchi
2023-01-31 17:35   ` Tom Tromey
2023-01-31 18:22     ` Simon Marchi [this message]
2023-01-31 17:35 ` [PATCH 1/2] gdbsupport: allow passing nullptr to checked_static_cast Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba4d1319-a9d0-9121-8c07-8d854ccbbaa5@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).