From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ulUm=54=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 14C133858D28
	for <gdb-patches@sourceware.org>; Tue, 31 Jan 2023 18:22:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14C133858D28
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [172.16.0.146] (192-222-180-24.qc.cable.ebox.net [192.222.180.24])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 2781E1E0D3;
	Tue, 31 Jan 2023 13:22:16 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1675189336; bh=k1xMVOk60aSCS+uXt6Bshj6ryu82idd5z5emeSB3OBs=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=UX4ZGMIQLW75FIGz3M0SEBboaimEtACqo8uXLm99cVR4e/daADH9HlXE9DyMdCcTp
	 WC2kLmeJUqALKVurUFvdHZ61vequjtYkRxKoXMaDHddFAnBaDARxL0D1gwPR0Oux1U
	 4kaIWUc1uW1s2I90PeqhBl04L1LlSOHj1sE99wlA=
Message-ID: <ba4d1319-a9d0-9121-8c07-8d854ccbbaa5@simark.ca>
Date: Tue, 31 Jan 2023 13:22:15 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] gdb: add nullptr check to
 cooked_index_functions::dump
Content-Language: fr
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20230131155721.21847-1-simon.marchi@efficios.com>
 <20230131155721.21847-2-simon.marchi@efficios.com>
 <87wn52li84.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <87wn52li84.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 1/31/23 12:35, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Print the "Cooked index in use" message after the nullptr check, such
> Simon> that if the cooked index failed to build, that message is not printed.
> 
> Thank you.  This looks good to me.
> 
> Tom

Thanks, pushed both patches.

Simon