From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 7B11D3858C39 for ; Tue, 28 Nov 2023 05:46:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B11D3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B11D3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701150410; cv=none; b=pzU4HxyR/q2kFDD2S9vTw1/fTfol4ds7AafrcG+oHDzRgnI/ymyCtqN3Eqst/yEplotIt2NjS5H0O9Xx3W4ir0XRi4n93EEFSS2M9gFy7Glgevx5uUK3qM+Tc1KRA1cc16e6+/OuMARREF5rBlyrm7040izOJoXwn5mvgcAWfqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701150410; c=relaxed/simple; bh=+6sxRUzHofg6kRDZb8lFSyvDim1BnsmFPQsoZeFC8MA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pjQTUKwwYKiB/1gh/Z/tdlabw9Wy3Zd9xsR4NBwYUmy2fzF7KFI8v73tb7L+0IEjBmUNL8KVxakaX7g4zCt8sSwqr5Z/MrmkeS8+xMpcaa2I9St0/iSL6x2xsmbNTloCW02yH13BeP1wgMzJXFJ3394f6F/+WZL3tFZmdLycqB0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1cfd04a6e49so13743375ad.0 for ; Mon, 27 Nov 2023 21:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701150407; x=1701755207; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pBth+HO5AEYXAhFoObB74yYYtoJBM/MGnBIxehse5Ek=; b=SkZ1tOXtjdleh83uVM46oZ5Oc2TQ8MEgDXuL4cJiiE/sR3JZ2hgmOYGropkY9/5Sou 3O2sZo15oozEggbsNW6tpyo6zdiaavH10bCbdesmlLuELGuOh/zhGmNdEwF/2qHTeDll ilL/EdGgxhffY7mH0NJjOCvQ4xGveEUxHfjwxUvAaEGra2XPx5bO3QZwUMck95Tt3O7B OSX636jnqWPlAtjhDy07lZI5Vt7C+XRD4HUkcQkCu4mChn2uOyhkl+oeyzHaJhs0eU8p AHl2Nj3Z7A3J4iL3y7qowU9t0cI0b8PrkonUIZ+vdQTLifhSBRoHuzfqR6Xo3Sl95d+M +LyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701150407; x=1701755207; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pBth+HO5AEYXAhFoObB74yYYtoJBM/MGnBIxehse5Ek=; b=EyUkA1EhwHWqvbOSzY9e+PP371AqAlJN30k+mCuoWnitu7V+kZFKMmDi9o+WYxn0bs 4/yPOOJKVyol/AJm9aJm0O4wwxO8p13CS8VhC3KERIUAq6spRuQGBnIRrvCcC8Z90skM jRp99AZYvAWFQ7tQwuG5FaqgDaTjLNWmGuLhd8lQ5qyPvYd90EEBZuk2nU7G4dAbb6wu ynjn4ql9iOojHqKxJ2KM8bwkxeiyXNOl2Ggt1k0gBQS7/T0OIDdVW+r2gFm4hv59co6L JYsoqUTBDFzQnANOk/+m9FUKb7m9rhsznUj+GRDxMywHLSWeWVuJ6EKb20s7b1wttna+ wFZg== X-Gm-Message-State: AOJu0YxvUzMU0IFxYSmehrfxOqAHGJaRr/oZh5l5QT7Ef7epkIHG2KUw kwup6ilBtOaONCVaqCifstjzytBkE2tGzw== X-Google-Smtp-Source: AGHT+IFW5ZaUCKpRXnglCFwHGxWOvFMOuTJx0U+NK29pUXGypGvFd9NEfrjqomQ/If6yUzTbaZjyTQ== X-Received: by 2002:a17:902:f543:b0:1cf:647a:9d3d with SMTP id h3-20020a170902f54300b001cf647a9d3dmr19985165plf.28.1701150407459; Mon, 27 Nov 2023 21:46:47 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id h7-20020a170902748700b001c5dea67c26sm9214191pll.233.2023.11.27.21.46.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 21:46:46 -0800 (PST) Message-ID: Date: Mon, 27 Nov 2023 22:46:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Another fix for the mcore simulator Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20cefa11-9565-47f5-b1bc-bd90e8c428fc@gmail.com> <87ttp7dkqt.fsf@tromey.com> From: Jeff Law In-Reply-To: <87ttp7dkqt.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 13:06, Tom Tromey wrote: >>>>>> "Jeff" == Jeff Law writes: > > Jeff> No doubt there's more 64 bit host issues in the mcore simulator. I > Jeff> can't justify chasing them all down preemptively. But I'll obviously > Jeff> continue to fault in fixes if/when the GCC testsuite shows a > Jeff> regression. > > Jeff> OK for the trunk? > > I don't have any issue with the patch, but I confess I don't understand > what the bug was or how the patch works. > > Jeff> unsigned imm = IMM5; > Jeff> - unsigned long tmp = gr[RD]; > Jeff> + uint32_t tmp = gr[RD]; > > IIUC gr is a uint32_t so this patch seems like it just removes a zero > extension and then a narrowing cast. "gr" is actually a "int32_t", so it's signed. But even so, if it's stuffed into a "unsigned long" it's going to be zero extended. So I certainly see your point. Given there's some confusion here, I'll revert it out of my tester which should result in seeing some failures return and I can dive into the simulator again to extract the relevant state in the lsri/lsr instructions. jeff