From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) by sourceware.org (Postfix) with ESMTPS id 364503858D20 for ; Mon, 30 Oct 2023 09:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 364503858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 364503858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.81 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1698658711; cv=pass; b=FkPuJ461Gz0h3Ubux3EKLZaSjwCCC8YoSsMBmpxwMWeDHiWhYMqiZdurkNIFNrrzFMhNP5sUltPvjL5L33P2NbFQU+SotBWFFrjn9riEexAGr6Y/fcVTOhokq3mYJj6m2MmV+7Hz4wKvYyurl1ZYgbE4ZAI35l42k42zylo22UI= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1698658711; c=relaxed/simple; bh=NJAxbjhZcWCDINsXhdqqT6JeeBZfG/r1Im+9irBXLzU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=HERT+EA6Ar8sv7sqbJDqfBMpipN8WRxcBQaR5Pdv5XIXxu7wZEB/sRl74uvJx/wXV3L82Imj+ob8acdu+HNTr4QCvzHu5/bqATuoGFwc/L72p+2tXrEvqajPOitFQBMWHLMXGF0UwlPqz1ROTVNCMdec4Z3+Wo/3fYI3/5nR5Gg= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=U/76oxu2ZqdWhCiLTfvTYNvl/5mrJqV64Ho2WoglIdcf648r+Xk0PbP6e6hfm3rKwE/LIHAEl3jD4bVvWm5tcsBctLXZ5lkEQ3FgsJKruEwBQZycsb8g8befLGs5fl9xh+I4jsisyWhJRnKeIDQTzOVXESuWbwqrYNucyLHq2UfgThgbIAyd2/9sop7wliaLRFwZ9muVIpZVH/2kvMovgYkw1hQSvUK1bZZUz+ty1Qvq29+YNIAzmTZxKgJKpzvNqJAjoHcFDWiYydBAwYDM6KJ8Ub7Pf7u0ZGCRnCuHEKb2YU2nmBjDt53BZa0C60bl/jl2VjizQZHmjhL3MwDnPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0r7zG+Kbmv6bWaODBiTLVoMrHwV0yUWxlgGgIz7Ndi8=; b=RzHug71KCuqRxMQlE2w6ARp8ux637RnRiSQU/msYvZ0Mao4jMx+y7AHBlymc2M+vPUPlvvIr5VsuVa8LO+R4yRAuP0SIY91wXrSqZXs1zMlcaWyJCigetUGdNYRnY6iOS+qiZ5Z8RqnAh0spj01JIto1PABrSWYPtQwDafZPmjl9F1h1ySh2DQLbu5sN3a4fkhk1GC17JlZ2tS4Wd2JQYqHkLkAz0ZFX4bblDqI+aTBnI2thMZKrN1TzC9LL58a73XGOpqI+U9K2OVwqOGJyVXGfDmtIyphbzHHLrdMVdYRjzCStyXbn2Giuf5Xu3aptDV8MtuEc/A+lEDMJW7O/wg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0r7zG+Kbmv6bWaODBiTLVoMrHwV0yUWxlgGgIz7Ndi8=; b=jzJIoU+ajDLpn78Rc/i3avPJlOOc/xZeDuEX/Y7/JPiEU7v7fJY4hmuMoG2/2KkBqgPkdljwH4+OmiSWWbaZbGqaaxf4XQpPPuaPdbEDDZtufMAcH5OI2axr86VbZyJQRrBo0NcHqoITH/ENenqN6ZT6cjYLMk3uvnjhb18UQkI= Received: from AS9PR06CA0018.eurprd06.prod.outlook.com (2603:10a6:20b:462::11) by PAVPR08MB9628.eurprd08.prod.outlook.com (2603:10a6:102:31c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.24; Mon, 30 Oct 2023 09:38:26 +0000 Received: from AMS0EPF00000199.eurprd05.prod.outlook.com (2603:10a6:20b:462:cafe::d9) by AS9PR06CA0018.outlook.office365.com (2603:10a6:20b:462::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28 via Frontend Transport; Mon, 30 Oct 2023 09:38:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000199.mail.protection.outlook.com (10.167.16.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 30 Oct 2023 09:38:24 +0000 Received: ("Tessian outbound 5d213238733f:v228"); Mon, 30 Oct 2023 09:38:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8e699676513f7c99 X-CR-MTA-TID: 64aa7808 Received: from fccb030dd397.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CAEE116A-53A4-4319-A4B4-A9AF9A36E51D.1; Mon, 30 Oct 2023 09:38:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fccb030dd397.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 Oct 2023 09:38:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBTJIn5OEi7xsaomzIn4R+L2V4EwOmpFq2lGNjY7ucvSVXm00E8M77xARjWOIMX+GV5bNfM0n6nPmpnD+oB3SoPUHUyvDZ8i/5S/ussKqrZKcKBSbVpOFYqk24aEUvy5swqx+Hri4j420T3hgu2xQuXAxSutD5Lwb7o6QH/Yq5vqQrzIwp/LLdjamZkVgKoQaE5o/3CnrPxcgBai7kYvAVyrqOWzASYlhXdNk9vlUyViYqXINRMuhRiMN8njHZO4dRvcZPd0ESbn8qLPaCjAmcl4b48SveThRPbfNMqp0K9dCHsFgqKV72wRA6l0BEP5cj2zwhW5oq3o9IKI5FC1zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0r7zG+Kbmv6bWaODBiTLVoMrHwV0yUWxlgGgIz7Ndi8=; b=fz4xLf5BANRllHEUpecSg6oyD/UZHe07DC6dtBIiKobqgHmJcrgiDbUXnn+Wij4DqTSdw0v8htelg+kpUsY6oXfzR5vBzc56Ek/oy34Z9h1wreBxsUlt68+XPm/FOaGwKWwhvz89akajvzP1FJVrpa1EHQRq+2NfpVNO11q+pojXd1Flnitx5ZdesvPplAks3DxACxTwYUFvw8pZr/jjlPXDbantqpG9bPDBGvYC1Qi1gRHfOUAR7PpeECObk+FPxDEBgHL1VSbowY6AH6pClTvM6ArcBoU3XemGkYBKOWlvvRGX4FDSbtzACbFce6n83YgwI2SuFehzoPVxDLjm1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0r7zG+Kbmv6bWaODBiTLVoMrHwV0yUWxlgGgIz7Ndi8=; b=jzJIoU+ajDLpn78Rc/i3avPJlOOc/xZeDuEX/Y7/JPiEU7v7fJY4hmuMoG2/2KkBqgPkdljwH4+OmiSWWbaZbGqaaxf4XQpPPuaPdbEDDZtufMAcH5OI2axr86VbZyJQRrBo0NcHqoITH/ENenqN6ZT6cjYLMk3uvnjhb18UQkI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB8717.eurprd08.prod.outlook.com (2603:10a6:20b:55d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28; Mon, 30 Oct 2023 09:38:16 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::3e05:d9f5:3a1c:4b2f]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::3e05:d9f5:3a1c:4b2f%5]) with mapi id 15.20.6933.022; Mon, 30 Oct 2023 09:38:15 +0000 Message-ID: Date: Mon, 30 Oct 2023 09:38:12 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] Fix calls with small integers on ARM Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> <20231020-arm-params-v1-1-19d4c89c11b6@adacore.com> <871qdglyzh.fsf@tromey.com> From: Luis Machado In-Reply-To: <871qdglyzh.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0509.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::16) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB8717:EE_|AMS0EPF00000199:EE_|PAVPR08MB9628:EE_ X-MS-Office365-Filtering-Correlation-Id: 93893c93-21cf-404d-045a-08dbd92bf6c4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JCqPjW2WH+3FdneAOOw7xkB6Kaaz8fUwBx2lMIafua3tbQW986oltC7E+b1Svn5zx24+eVhoeMs6ZqT9/6L/FRhDf04vnh+bcBsx2z/uj/26EzNZE+LyWD7HjzL2uZ+itTVG6fSbFUV9zFUIZtrPxZekBcGLrpT7W7cDZFsF/rCMh4B8yZTvQAkBjzP+2iKrBPRcKW5lnmAro1g80Wg/ef2XV4knyJbjTnDFGQMhbqShf9cuVMGZ/YcfUJbHwMzldS5V/l82bUOrNk7se0DB+riKTUrsbOltUgPg0QYenhDrUrw97L1DQVyz+dpj/HgzZX1zfcfjlzqbOi3o8RVSc0sACkjmGAji/7iSSfdAgcL8Vxrc93a291axTIQA/APpqzPfUce0lQwI0xXu0Qg7LvA/9bwvKxh1RoFk+B0KhgMV2w/XE7cbbAGPhVLFBm3w2DFTdiCiO3CixJBmimoMBrpAB3mJdi2QOQ1OFkn9ZoUo4DnJ+ggd8BScksPtWSrOeP3iSd6znV8n1hyO+S7cEXAQbIoS5yzurkj1Ioylmro+029YwiH80kIfA1MwY/GccXlsjjwlNipGvpdyfeB1KB3+Ddu/PmlZ0OSQZcnHn5c70zXaIkNV9BS4IRPf2o6PFUWU0mZ9XQ/uuOAOYjhu5g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(39860400002)(366004)(346002)(376002)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(83380400001)(26005)(2616005)(66556008)(38100700002)(316002)(6916009)(66476007)(66946007)(5660300002)(53546011)(4326008)(8936002)(8676002)(44832011)(6666004)(6506007)(6512007)(2906002)(6486002)(478600001)(41300700001)(36756003)(86362001)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8717 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7579d884-6439-42c9-0744-08dbd92bf147 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k08RzPTHPLFkoYR2Nqb6svp3rKTmc5oIsI7NzEbPwdCytw2SQOmEI+cY2WJNDvg0wyVGzc6zbf/2WtproJ3dNcP8nXWLdQgGl9SWUcT3HeS5J61pFgYGq/c0GwjPehbmx1fs8mB+yhtu7ufw9/pu3Cc11u/ChiHMKQu7U6aJQAicY10tEDMP+CHpTZnFFoSrsPgIhrcVrXhE5OEfX1OE4xi3gl/6SdmaeVkTpZJDxQ/E7riDJIS8NXhwGq+7Lv8QmBRSqo6SYKdKM4oSOQO1lIy9hLtjdM+xbPkvQt/1Y1v8Cwwgyg6a59xq5nV6qJ7lGlNcy45VaM5LVM8Alky3OinQmHvVM2a+ri1OKdKNGfLhFsPJeUtu6kcu3dzHEi1rwqo26RUw1g924llqI8gHOC9IEkbyFSyWbG66ySn6iKYvLj1prV7O727uh1Il4i+SqGngG0zcLsLz5n76yVP5g5auE7eNb0TdFsIygYftG5UD48M7h3PJbEYusrJWj6D8/GzSS7PWeABj8uMqNdYtTQuwPCQsxnkxcBl+w0Vk/S/AQDdDg5PW4v5RdyRQLFx5hcRSpSTL+T0tFtfHrcRdln9rH1d0/hSwIQ5JG2F8ISuuLl3skxGupmYnrG9KFL6eKpAqGgpD44RR+sr44QFN+CONAP9SEUBLMGB/hq01ujsbw8mfJtliMRjVUh0/NG7mOrWKQTkP8rJyyOdULRz4N2IHGi2Uijp1w2oIelgN6mKfooq19gvUJukBTLQ5uHcJib9s2uvs2ojjTua9+2VIwA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(346002)(136003)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(82310400011)(1800799009)(46966006)(40470700004)(36840700001)(40460700003)(40480700001)(6506007)(53546011)(478600001)(6512007)(6666004)(336012)(2616005)(5660300002)(26005)(6862004)(2906002)(44832011)(8936002)(4326008)(6486002)(8676002)(41300700001)(316002)(356005)(82740400003)(86362001)(81166007)(31696002)(47076005)(31686004)(36860700001)(36756003)(83380400001)(70206006)(70586007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 09:38:24.9450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93893c93-21cf-404d-045a-08dbd92bf6c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9628 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/27/23 19:08, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > >>> @@ -4824,9 +4824,6 @@ arm_push_dummy_call (struct gdbarch *gdbarch, struct value *function, >>> { >>> /* The argument is being passed in a general purpose >>> register. */ >>> - if (byte_order == BFD_ENDIAN_BIG) >>> - regval <<= (ARM_INT_REGISTER_SIZE - partial_len) * 8; >>> - >>> arm_debug_printf ("arg %d in %s = 0x%s", argnum, >>> gdbarch_register_name (gdbarch, argreg), >>> phex (regval, ARM_INT_REGISTER_SIZE)); >>> > > Luis> Do you have an example failure for the above? Is it a positve or > Luis> negative integer? > > I backed this out and ran the internal tests, and it fails on one > Ada-specific test involving fixed-point types -- but also on the > internal equivalent of this test from gnu_vector.exp: > > gdb_test "print add_singlevecs((char1) \{6\}, (int1) \{12\}, (double1) \{24\})" "= \\{42\\}" \ > "call add_singlevecs" > > Luis> But looking at it now, it isn't really clear what the > Luis> left-shifting is supposed to accomplish, as regval should be > Luis> padded/sign-extended from extract_unsigned_integer. > > Yeah. > Probably untested BE breakage. This code is really old, and gdb has seen a lot of changes to regcache functions. > Tom Thanks. Approved-By: Luis Machado