Re: [PATCH] gdb: remove TYPE_FIELD macro

[Simon Marchi <simon.marchi@efficios.com>]

On 2020-05-23 4:49 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Replace all uses of it by type::field.
> 
> Looks good.

Thanks, I'll push the patch then.

> Simon> Note that since type::field returns a reference to the field, some spots
> Simon> are used to assign the whole field structure.  See ctfread.c, function
> Simon> attach_fields_to_type, for example.  This is the same as was happening
> Simon> with the macro, so I don't think it's a problem, but if anybody sees a
> Simon> really nicer way to do this, now could be a good time to implement it.
> 
> Ultimately I imagine we'll just want a way to set all the fields at
> once, perhaps making a copy of them if needed; and then disallow writing
> to a field.
> 
> Tom
> 

Perhaps, I'm not really there yet.  I think it will still be useful
to set just one field, some languages do that I believe.  But it could
be using a type::set_field method, this way it's easier to trace /
debug.

Forcing to set all the fields at once would just force the callers to
do more work, without any benefit.  If they copy the whole field array,
make a modification, then set the whole field array, it's essentially
the same as just setting that single field, isn't it?

Simon