From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7FA983858406 for ; Wed, 29 Sep 2021 17:48:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FA983858406 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-9K46fb7oPcKjhUGIl_GeXQ-1; Wed, 29 Sep 2021 13:48:30 -0400 X-MC-Unique: 9K46fb7oPcKjhUGIl_GeXQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5EC31023F4E; Wed, 29 Sep 2021 17:48:29 +0000 (UTC) Received: from [10.3.115.6] (ovpn-115-6.phx2.redhat.com [10.3.115.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD4755C1C5; Wed, 29 Sep 2021 17:48:29 +0000 (UTC) Subject: Re: [PATCH v2] gdb: Print debuginfod first-use notification To: Aaron Merey , simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org References: <20210929010906.194578-1-amerey@redhat.com> From: Keith Seitz Message-ID: Date: Wed, 29 Sep 2021 10:48:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210929010906.194578-1-amerey@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 17:48:33 -0000 On 9/28/21 6:09 PM, Aaron Merey wrote: > I realized I never updated the debuginfod first-use notice patch[1] > with your feedback. I've included the revised patch below. I took a "quick" look over the previous thread (thank you for linking it!) and Simon's comments. AFAICT, all comments/recommendations have been addressed. Although I will say, I am not a fan of: > + scoped_fd fd = (scoped_fd) gdb_open_cloexec (used_p.c_str (), O_CREAT, 0); The more canonical way this is done in gdb is scoped_fd fd (gdb_open_cloexec (...)); YMMV > Keith also asked a good question[2] about whether or not to add > interactivity to the first-use notice. Do you have any thoughts on this? While I would like something more "interactive," I am not going to stand in the way of progress (for which perfect is the proverbial enemy). I recommend this patch be approved. Keith