From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 46F123858D35 for ; Tue, 7 Jul 2020 19:51:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 46F123858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Paul_Carroll@mentor.com IronPort-SDR: hVl97C6SsJFb/BXEl3MbbT0QwpXeFTBP/tDpMwLzFmwNHCAh7miPj++wwP63q7nZlsOoSxegXj DKebm2l8mBtKdK9RoDd2wk7B3KfyQpclVTtTraRGm8ajf9o9yvMHkcGIl73OU0aLuYrsAtiUj+ 0M2YO4ZtH3CIxSf1Pe1hQpG0AjG/P0wCSePKFmR1gGi9ZaGfW0fAL2zMH/hiqNxYHfI+y+fKWv ASYu0+r42ICg81Z6Jd/0MBsn0ju6y667vSQB3ef2RrE4yAv+Y1XWPLurE17+OB4occyxljtOYz CdA= X-IronPort-AV: E=Sophos;i="5.75,324,1589270400"; d="scan'208";a="50672685" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 07 Jul 2020 11:51:21 -0800 IronPort-SDR: Pk9H1IkVgUdE/FWQN/z+ujm3GohM0F2aqCJBVWqNifbmpACSwImI30jaMczuHKXH3n938XBsEq jF9dPOAGIKtmqUjut9dKSIh++MNqHgLfVu1jNKf0OkzVhOxDCMTSBvJg1EyQSuGafIwRhKmTjY KkdndvCC3wzLjJUDQDXLfl7WX48L0+zduHEoq6UTtbVgIKLFaWeaVu/Eq/QU+rYzoeXEdXzi84 mxp5C2ivRdFM2b9zD5FkIzh5XUUParZ+0y3azCgzIFDbq8hAjjTEOac/7BD15WozlRfuhS8ame Z+U= Subject: Re: [PATCH][PR gdb/25716] Modify Docs to avoid HTML filename collision on Windows To: Andrew Burgess CC: References: <643ebaf3-211f-c240-f5d7-88e47b1631d8@codesourcery.com> <20200707154551.GZ2737@embecosm.com> From: "Carroll, Paul" Message-ID: Date: Tue, 7 Jul 2020 12:51:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200707154551.GZ2737@embecosm.com> Content-Type: multipart/mixed; boundary="------------A4AB7187DD2FC2B610E57A14" Content-Language: en-US X-ClientProxiedBy: SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 19:51:23 -0000 --------------A4AB7187DD2FC2B610E57A14 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 7/7/2020 8:45 AM, Andrew Burgess wrote: > Lots of whitespace in this patch was replaced with '_' for some > reason, which means this patch didn't apply cleanly. Not sure where > this has occurred, but I don't see this with other patches, so I'd > like to say this is something at your end. Somehow an extra space was added for lines that started with a space.  No idea how it got there.  Copy-paste error. >> adjust xrefs to it. >> >> --- >>  gdb/doc/gdb.texinfo | 5 ++--- >>  1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 59e3e75d18..5301e98fee 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -3600,7 +3600,7 @@ is, using: >>  @end smallexample >> >>  The @code{tfaas} command accepts the same options as the @code{frame >> -apply} command.  @xref{frame apply}. >> +apply} command.  @xref{Frame Apply, frame apply}. > I wonder if we should use '@xref{Frame Apply, , frame apply}.' here? > > Currently in html we get: 'See frame apply.' > And in a pdf we get: 'See [frame apply], page 112.' > > After this commit the html stays the same, but the pdf changes to: > 'See Section 8.5 [Frame Apply], page 112.'. The new 'Section xxx' > doesn't bother me, but 'Frame Apply' is not the name of the section, > nor is it the name of the command. > > With my proposed change then the html version stays the same, and the > pdf version becomes: 'See Section 8.5 [frame apply], page 112.', we > now name the actual command. > > What do you think? > > Thanks, > Andrew Looks good to me.  there are 2 xrefs that would need the same change.  From what I generated, the PDFs show the difference while the HTML files are identical.  So, yes, it matches what you indicated. I'm attaching my patch with your change. --------------A4AB7187DD2FC2B610E57A14 Content-Type: text/plain; charset="UTF-8"; name="0001-fix-for-pr-25716.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-fix-for-pr-25716.patch" LS0tCiBnZGIvZG9jL2dkYi50ZXhpbmZvIHwgNSArKy0tLQogMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvZG9jL2dk Yi50ZXhpbmZvIGIvZ2RiL2RvYy9nZGIudGV4aW5mbwppbmRleCA1OWUzZTc1ZDE4Li41MzAx ZTk4ZmVlIDEwMDY0NAotLS0gYS9nZGIvZG9jL2dkYi50ZXhpbmZvCisrKyBiL2dkYi9kb2Mv Z2RiLnRleGluZm8KQEAgLTM2MDAsNyArMzYwMCw3IEBAIGlzLCB1c2luZzoKIEBlbmQgc21h bGxleGFtcGxlCiAKIFRoZSBAY29kZXt0ZmFhc30gY29tbWFuZCBhY2NlcHRzIHRoZSBzYW1l IG9wdGlvbnMgYXMgdGhlIEBjb2Rle2ZyYW1lCi1hcHBseX0gY29tbWFuZC4gIEB4cmVme2Zy YW1lIGFwcGx5fS4KK2FwcGx5fSBjb21tYW5kLiAgQHhyZWZ7RnJhbWUgQXBwbHksLGZyYW1l IGFwcGx5fS4KIAogQGtpbmRleCB0aHJlYWQgbmFtZQogQGNpbmRleCBuYW1lIGEgdGhyZWFk CkBAIC04MzU4LDcgKzgzNTgsNiBAQCB0ZmFhcyBpIGxvIC1xIC10IGxvY2tfc29tZXRoaW5n X3QKIAogQG5vZGUgRnJhbWUgQXBwbHkKIEBzZWN0aW9uIEFwcGx5aW5nIGEgQ29tbWFuZCB0 byBTZXZlcmFsIEZyYW1lcy4KLUBhbmNob3J7ZnJhbWUgYXBwbHl9CiBAa2luZGV4IGZyYW1l IGFwcGx5CiBAY2luZGV4IGFwcGx5IGNvbW1hbmQgdG8gc2V2ZXJhbCBmcmFtZXMKIEB0YWJs ZSBAY29kZQpAQCAtODQ5MCw3ICs4NDg5LDcgQEAgaXMsIHVzaW5nOgogQGVuZCBzbWFsbGV4 YW1wbGUKIAogVGhlIEBjb2Rle2ZhYXN9IGNvbW1hbmQgYWNjZXB0cyB0aGUgc2FtZSBvcHRp b25zIGFzIHRoZSBAY29kZXtmcmFtZQotYXBwbHl9IGNvbW1hbmQuICBAeHJlZntmcmFtZSBh cHBseX0uCithcHBseX0gY29tbWFuZC4gIEB4cmVme0ZyYW1lIEFwcGx5LCxmcmFtZSBhcHBs eX0uCiAKIE5vdGUgdGhhdCB0aGUgY29tbWFuZCBAY29kZXt0ZmFhcyBAdmFye2NvbW1hbmR9 fSBhcHBsaWVzIEB2YXJ7Y29tbWFuZH0KIG9uIGFsbCBmcmFtZXMgb2YgYWxsIHRocmVhZHMu ICBTZWUgQHhyZWZ7VGhyZWFkcywsVGhyZWFkc30uCi0tIAoyLjIxLjAKCg== --------------A4AB7187DD2FC2B610E57A14--