From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 7F3B73858D1E for ; Wed, 2 Aug 2023 15:26:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3B73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA0B91F381; Wed, 2 Aug 2023 15:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690989964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmzGZm1RfDbYJpPDQdGRhG7yryinI9/FqbCtUSbPuXw=; b=YBNBPQ6aj9SfP3DtnvmhiHK9gVaW1+ORVAOPD3dYSvKOk5Y7kUGO0Azf2tZpjSxK86h21h UoTbswigEWmrucSBaQFK70C1lOnClQAJFYf8zqG3Bu5c1HPdekNEMk2ago+oMAHcpsqfGP ZwTjQ1VzuerWAx+is0+zX5zf2gCJtDo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690989964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmzGZm1RfDbYJpPDQdGRhG7yryinI9/FqbCtUSbPuXw=; b=7NtnptdgQJmpsu0Z8g6FnLLhtToYqUnQHHbH2jfxHubDoTisngFOp/ffboRVTD2UWulBfM SnSyie8pn9YxYSBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A582D13919; Wed, 2 Aug 2023 15:26:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kuooJ4x1ymSMLAAAMHmgww (envelope-from ); Wed, 02 Aug 2023 15:26:04 +0000 Message-ID: Date: Wed, 2 Aug 2023 17:25:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix bug in fixed-point handling Content-Language: en-US To: Tom Tromey Cc: Tom Tromey via Gdb-patches References: <20230719152442.67508-1-tromey@adacore.com> <87zg3cf33d.fsf@tromey.com> <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> <87v8dyg79g.fsf@tromey.com> <5d7c9731-5c3c-5b07-17a3-d5f2eb2de7f4@suse.de> <87il9xfpk0.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87il9xfpk0.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/2/23 17:10, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Yes, the test-cases passes for gcc 10, 11 and 12, and fails for gcc 7, > Tom> 8 and 9. > >>> I'm wondering if the appended is enough or if it should be conditional >>> on gcc 10 specifically. >>> > > Tom> With the patch applied, it passes for all the above. > > Would you mind trying the appended? It tightens the test to make it > specific to the "all" scenario and to be skipped only for GCC < 10. > Tested with gcc 7 - 12, only expected passes. Thanks, - Tom > thanks, > Tom > > diff --git a/gdb/testsuite/gdb.ada/fixed_points.exp b/gdb/testsuite/gdb.ada/fixed_points.exp > index 2edc63f4071..05e86b9d0ed 100644 > --- a/gdb/testsuite/gdb.ada/fixed_points.exp > +++ b/gdb/testsuite/gdb.ada/fixed_points.exp > @@ -92,6 +92,9 @@ foreach_with_prefix scenario {all minimal} { > gdb_test "print fp5_var" " = 3e-19" > } > > - gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ > - "value of another_fixed" > + # This failed before GCC 10. > + if {$scenario == "all" && [test_compiler_info {gcc-10-*}]} { > + gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ > + "value of another_fixed" > + } > }