From: Pedro Alves <palves@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: xtensa: handle privileged registers
Date: Mon, 07 May 2018 16:50:00 -0000 [thread overview]
Message-ID: <bb01fd11-d5ba-2782-4af6-f2292e196756@redhat.com> (raw)
In-Reply-To: <CAMo8BfLA6nhLA1oE4S795QJkD4hBH=QZ+8TUzDd7yxtFyn_k2g@mail.gmail.com>
Hi Max,
On 05/07/2018 05:23 PM, Max Filippov wrote:
> Ping?
> The fix was verified by the reporting party
> ( https://github.com/zephyrproject-rtos/zephyr/issues/4309#issuecomment-387017968
> )
> If there are no objections I'd like to commit it.
It would help if the the patch included some rationale/explanation.
Like:
- what is wrong or broken currently,
- what does the patch fix,
- and how.
Could you please resend the patch with that info included in
the proposed git commit log?
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-05-07 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 2:42 Max Filippov
2018-05-07 16:23 ` Max Filippov
2018-05-07 16:50 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb01fd11-d5ba-2782-4af6-f2292e196756@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jcmvbkbc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).