From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 37539387084D for ; Mon, 22 Jun 2020 16:28:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 37539387084D Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-HhNwNRCdNbCNj6_tB5TAng-1; Mon, 22 Jun 2020 12:28:23 -0400 X-MC-Unique: HhNwNRCdNbCNj6_tB5TAng-1 Received: by mail-wr1-f72.google.com with SMTP id w4so11169371wrl.13 for ; Mon, 22 Jun 2020 09:28:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+Vlswol5rn9iF5FbDPtN6Wtftrr3fLVXz2WvQJoF+GY=; b=EW2TGshobdtr/AJMHwZ8bryeelFaGPHOaoV76aZGrwzkUNkJFFZntKIiwxSAJkryo7 diAHaG87rYIHa/WMmfMySJLOI4S4+S3dPvzZp/zToOfIaBB/VN09yVCksRzBKyI5hzFc LQ1HvTqdlMtKIk083p5r61ljvbEIN5uwsh3De4Hl+71S8x3k87TAQFsdJQCvwXuO6TC1 ft7J97x78ejT1ABOJ1DcfnbAeB4LAUdi5RgYWueuapYRbQ8QsCQ/6QMHEzNJQkuTs1v7 V2PymJjKf5zRMRezBO7aGFYno7XvNvNWSuJKYNnLYthF/F+0v0AZd1MJJLPvT2tRso22 ATVA== X-Gm-Message-State: AOAM5311B+NG4oPpmVgfGYJtN36ksJH36rZMX2fFVjgz4XIuUcfNhqot 2fPejH55wa36uDGHLNPo9fWgT0YhKO5JammsBNXGRyIY6iGTZG5U/a6z4d/1s4ogngqHp02umtW Dr1k+L/SQ99YLMFfBUdfcRQ== X-Received: by 2002:a5d:4a4f:: with SMTP id v15mr19156182wrs.87.1592843301959; Mon, 22 Jun 2020 09:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxph0MrPAJmdtcUZBoSQEDGigXd4YP8fUSO1cplNz1QZ48P3lmEhZTsvKaEbFMQEwLhfbQAKw== X-Received: by 2002:a5d:4a4f:: with SMTP id v15mr19156166wrs.87.1592843301744; Mon, 22 Jun 2020 09:28:21 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u74sm75120wmu.31.2020.06.22.09.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 09:28:21 -0700 (PDT) Subject: Re: [PATCH v2 3/3] gdb/jit: enable tracking multiple jitter objfiles To: Simon Marchi , Tankut Baris Aktemur , gdb-patches@sourceware.org References: <4f7d8cfd9635484c5148e72f0941a0d9f369b7f3.1592299502.git.tankut.baris.aktemur@intel.com> <40e500a7-81ab-280a-1e40-d737d9aeb93f@simark.ca> From: Pedro Alves Message-ID: Date: Mon, 22 Jun 2020 17:28:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <40e500a7-81ab-280a-1e40-d737d9aeb93f@simark.ca> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 16:28:26 -0000 On 6/21/20 4:32 AM, Simon Marchi wrote: > > I would prefer #2, because using registries is kind of our standard way to keep > per-stuff data (where stuff is objfile, program_space, inferior, etc). I'd just like to point out that the main point of the registry mechanism is dynamic registration, which is useful when you have parts of the debugger that may or not be present in the final build. E.g., per-stuff data that is only used by some -tdep.c file. Otherwise, if we're talking about data used by some module that is _always_ included in the built, then IMO the registry stuff is an unnecessary abstraction. Thanks, Pedro Alves