From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90976 invoked by alias); 19 Oct 2016 18:45:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90908 invoked by uid 89); 19 Oct 2016 18:45:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112, sk:express, H*u:1.2.0, H*UA:1.2.0 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 18:45:54 +0000 Received: by simark.ca (Postfix, from userid 112) id 346A31E862; Wed, 19 Oct 2016 14:45:53 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 0AEF71E0F5; Wed, 19 Oct 2016 14:45:52 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 19 Oct 2016 18:45:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 05/31] 'struct expression *' -> gdb::unique_xmalloc_ptr In-Reply-To: <1476839539-8374-6-git-send-email-palves@redhat.com> References: <1476839539-8374-1-git-send-email-palves@redhat.com> <1476839539-8374-6-git-send-email-palves@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00580.txt.bz2 On 2016-10-18 21:11, Pedro Alves wrote: > [1] - I'd like to set the rule that types named with an "_up" suffix > are unique_ptr typedefs. I don't mind. It sounds funny when saying it out loud though, my goal from now on will be to introduce a class named "whats". It ends up a bit cryptic for somebody that doesn't know about that convention (newcomers), but then expression_unique_ptr might be a bit long. I did a quick grep for various converted struct names allocation keywords, I see there is still a bp_location = XNEWVEC (struct bp_location *, bp_location_count); Does that need to be converted too?