Re: [pushed] [gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

On 2/21/23 20:44, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> +require {expr [have_syscall time]}
> 
> I think simply "require {have_syscall time}" should work.

Thanks for the review.

Pedro already cleaned this one up, but I found it in another test-case 
as well.

Fixed by commit below.

Thanks,
- Tom

[-- Attachment #2: 0001-gdb-testsuite-Cleanup-unnecessary-expr-from-require-.patch --]
[-- Type: text/x-patch, Size: 1009 bytes --]

From 4f688a5dd7d5710e29f0606bf1c7aede8a6d115e Mon Sep 17 00:00:00 2001
From: Tom de Vries <tdevries@suse.de>
Date: Wed, 22 Feb 2023 09:35:07 +0100
Subject: [PATCH] [gdb/testsuite] Cleanup unnecessary expr from require line

In a recent commit I've added:
...
require {expr [have_compile_flag -fsplit-stack]}
...
but actually the expr bit is unnecessary, and we can just use:
...
require {have_compile_flag -fsplit-stack}
...

Reported-By: Tom Tromey <tom@tromey.com>
---
 gdb/testsuite/gdb.base/morestack.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/morestack.exp b/gdb/testsuite/gdb.base/morestack.exp
index b4d22187390..cc81522a51e 100644
--- a/gdb/testsuite/gdb.base/morestack.exp
+++ b/gdb/testsuite/gdb.base/morestack.exp
@@ -15,7 +15,7 @@
 
 require is_c_compiler_gcc
 
-require {expr [have_compile_flag -fsplit-stack]}
+require {have_compile_flag -fsplit-stack}
 
 standard_testfile
 

base-commit: 0676ec3c22f096bdf98b145b720feeef9493b5bb
-- 
2.35.3