From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1FDE43858D32 for ; Thu, 7 Jul 2022 13:56:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FDE43858D32 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 417F31E220; Thu, 7 Jul 2022 09:56:21 -0400 (EDT) Message-ID: Date: Thu, 7 Jul 2022 09:56:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Fw: RE: [PATCH] Fix assert pid != 0 assertion failure in AIX Content-Language: en-US To: Aditya Vidyadhar Kamath , Ulrich Weigand , Joel Brobecker via Gdb-patches Cc: Sangamesh Mallayya References: <5f142468-bc68-9128-d4d6-80cf36f12a48@polymtl.ca> <87169b93-8be2-5ccd-6b58-51b395a367bd@polymtl.ca> <4516dbf7-2655-39c5-0614-8235df05248e@polymtl.ca> <0ad5c21e-60fa-e52d-f70c-d2bc62e0ac74@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 13:56:23 -0000 On 2022-07-07 04:27, Aditya Vidyadhar Kamath wrote: > Hi Simon, > > I appreciate your patience to read our explanations, understand and suggest us the right path. > > I was not aware of minus_one_ptid. I thought since pid will be -1, if a child process in not fetched to send ptid_t(pid).. That change you made looks good. Thank you for your guidance for someone new in this project. > > Changing all function parameters will help us in our fork patch coming soon. So that change also looks to good to eliminate depending on inferior_ptid. > > Multi thread programs are not seen even from my end. Yes, there is some work for multi thread case. Will work on it finding out a possible solution sometime next week. > > Having said that, we can push the changes so that folks using AIX will not see the assertion failure for simple programs soon. It will be great if it can be done. > > Have a great day ahead, Ok, thanks, I pushed the patch to the master branch. Simon