From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/3] gdb: add owner-related methods to struct type
Date: Fri, 22 Jan 2021 14:42:01 -0500 [thread overview]
Message-ID: <bb56340a-5016-ae22-e591-09db13f3c3da@polymtl.ca> (raw)
In-Reply-To: <ae35db93-0c3d-db27-5f10-5745f86ec849@polymtl.ca>
On 2021-01-22 12:21 p.m., Simon Marchi via Gdb-patches wrote:
> On 2021-01-22 10:31 a.m., Tom Tromey wrote:
>> This comment got misplaced into the middle of the method.
>
> Oh, I did spot this before sending, I thought I fixed it, apparently
> not. Fixed now, thanks.
>
> Simon
>
Oh, I didn't test this properly, I now see some regressions, for example in
gdb.base/jit-reader-simple.exp. Looking at that now.
Simon
prev parent reply other threads:[~2021-01-22 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 3:24 Simon Marchi
2021-01-21 3:24 ` [PATCH 2/3] gdb: remove TYPE_OBJFILE_OWNED macro Simon Marchi
2021-01-22 15:33 ` Tom Tromey
2021-01-21 3:24 ` [PATCH 3/3] gdb: remove TYPE_OBJFILE macro Simon Marchi
2021-01-22 15:34 ` Tom Tromey
2021-01-22 17:25 ` Simon Marchi
2021-01-22 15:31 ` [PATCH 1/3] gdb: add owner-related methods to struct type Tom Tromey
2021-01-22 17:21 ` Simon Marchi
2021-01-22 19:42 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb56340a-5016-ae22-e591-09db13f3c3da@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).