From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 545663858D1E for ; Thu, 8 Sep 2022 10:23:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 545663858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id o25so647153wrf.9 for ; Thu, 08 Sep 2022 03:23:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date; bh=MasbYLT6eI8JXfqMMPDFn0weDwbnK7M8kGQ3YiQdwZw=; b=b/Gpp0Aq1W4JwysSH9kiGqi8Dq59so+ywce70UeTnJ+j6bri/nMf6EQgWaBv++G12i NnntllRbCX+hXV+dzGYjxJ4l9tqT+MefDt8hD+SOIyVdNCitPwNR5CJ+fFrJQ6my7ZmU aPNRAqtSXeC9taREGahTg4rTchflN4sM/kHnNdqovTwjpySJvLTVDj/9GJDL6QDyOJDr 2aMUyKS/nvy0NP8xnzw9btfOibPT2zp5saJsBqgVV3SYIu7pQvVtf0kL24ciNS5U2Vte wTidZyNHuaoEcIgM5r3WsHs01/6ndcP2VKgJHRKFqEHMb6bo1uOxBCPAHIchS921tN9n CP1A== X-Gm-Message-State: ACgBeo0rVbh8gtuX1s0fDDoHQ0ejapXPg0ZpI3RHyxr4QOcyoUpS6Zc/ EHEjO04TfS1rpCSTVn6lP//zWijMviPB8Q== X-Google-Smtp-Source: AA6agR6jWYyY7dFOlbFbYlYweAfkhEaphjWuHtiFG1oxwRSJm/bDthNG30rtEHzjlaCGDAw7IsmRYg== X-Received: by 2002:adf:e508:0:b0:228:62fd:932b with SMTP id j8-20020adfe508000000b0022862fd932bmr4788363wrm.410.1662632616435; Thu, 08 Sep 2022 03:23:36 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id t8-20020adfe108000000b00225213fd4a9sm20758766wrz.33.2022.09.08.03.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 03:23:35 -0700 (PDT) Subject: Re: [PATCH 1/1] gdbsupport: Fix config.status dependency To: Tsukasa OI Cc: gdb-patches@sourceware.org References: <363d921e5d135e1e8d964235add673beba7cdd21.1662617054.git.research_trasio@irq.a4lg.com> From: Pedro Alves Message-ID: Date: Thu, 8 Sep 2022 11:23:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <363d921e5d135e1e8d964235add673beba7cdd21.1662617054.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2022 10:23:40 -0000 On 2022-09-08 7:04 a.m., Tsukasa OI wrote: > Commit 171fba11ab27 ("Make GDBserver abort on internal error in development mode") > created a new substitution CONFIG_STATUS_DEPENDENCIES but this is used by > Makefile.in (which is not regenerated by that commit). After regenerating > it, it is found that CONFIG_STATUS_DEPENDENCIES value is not valid, making > gdbsupport fail to build. > > Since the CONFIG_STATUS_DEPENDENCIES value is used in the Makefile, macro > substitution must have a Makefile format but commit 171fba11ab27 used shell > format "$srcdir/../bfd/development.sh". > > This commit fixes this issue by substituting "$srcdir" (shell format) to > "$(srcdir)" (Makefile format). It preserves the dependency as Pedro > intended and fixes the build problem. > Whoops. > It also regenerates corresponding files with the maintainer mode. > > gdbsupport/ChangeLog: > > * configure.ac: Fix config.status dependency. > * Makefile.in: Regenerate. > * configure: Regenerate. This is OK, please push. Thanks, Pedro Alves