From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 360843858C2B for ; Thu, 17 Oct 2024 19:51:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 360843858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 360843858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729194708; cv=none; b=azbKpRU5YzJwU+Dk0Wjb3FpBSAEg26qz+4YxDkOH4cxTGnoVQv38GW5vA0a9Iot5J5deu5Dblsi9forLRol3vCmO/3FggW43VG7UQfYC2FOE63TjD581QI8h8Mo6vqCVzO0pyyaGwnV5npIOywHK9xn1WR1ErMP5IttqkUP+mnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729194708; c=relaxed/simple; bh=KPUv0P+L2Y+RRnwbBn22i2Ti7Q1xsrmO8h5klZrSCIg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=H+vrxKe12QMwpRVUn7wEK0p/v00fGDiVMw9aOlfsywiASlJyzgTHkdvRblVMzr4YWI+h/Yf/afDgLtf/dGTa1R48m0iyG/prbJl7nx9UrctsUlCGWtjNYJqFUjAwksl3zYio0Ylo5X0EGWkD4ntnNSAaR3MvYKOYDGVyq5u4O0E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729194697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ri//kHoVKQFC2RGE1xj43gyN9Ebl80PgoN2GnsGDAH8=; b=Wshl9m61gSDhGNhax60qENlvwflUhjyhBQCFuTtRvA+omw+YnJDUqmOUUrX+o1+sGOWknq 9p/1WkrtOygjwYYcOcHMK3yeMYrDas+Dbct/6Lc4zobGmvoFW79PXPAazPEDfSoK4x3UiZ g7DZd86Tq1dIekh0WvZEwEGNtmZFfos= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-X-oiqYMxNxOZSXlyI308aA-1; Thu, 17 Oct 2024 15:51:35 -0400 X-MC-Unique: X-oiqYMxNxOZSXlyI308aA-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7b11467e528so184787385a.3 for ; Thu, 17 Oct 2024 12:51:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729194695; x=1729799495; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ri//kHoVKQFC2RGE1xj43gyN9Ebl80PgoN2GnsGDAH8=; b=q8oacGJe80t5XE2uDtDgw+cd3kb7fNna6BdY/J+pAd20NnzYAMTlg4mHvWj2aC74V9 iTPc/PfOPTrwCth21wwrR1UuJRGlEANzeOCiHsUoIR4CtWw1jjKlTbFIwGDi3jNZI7dR Za94j4LyKOoaNHMhqLP0XtZSEw3h5uWyixC7xeimaCvE6FiQcLseMocb/IwE7IU56VjS wfjGnsihBdP+CvrygAV7skIXkwZIn65PG4DhFW4CQ2z5fcm9Pj5GPlBrVSo08kBvKNu9 eEKJ9Crox05h4JteAlaXK4lb/FAnaPWQzlJVWj268JvFDHKzgehEPRgJLE5eyeGXwdtP ZmCQ== X-Gm-Message-State: AOJu0YwEpDaSyy6BYrRkpxp/GMOPntqp5NRYvg7O8qppBDc054uZTbnS 4JgT2dpT2bDOl5b0qC93aFiiNaE1raT4lhGVkr4UwvkWIg+dUrntvE3MXQEQ6yA4b0g3qJIg5nT chjN9qTkeEPde2pJZ+GYvYvQ4zK14lo8XSP+s0u7HUvvf9MhFN7BYrcrfyZ4= X-Received: by 2002:a05:6214:5981:b0:6cb:c508:809 with SMTP id 6a1803df08f44-6cc2b9102b8mr141606856d6.34.1729194695387; Thu, 17 Oct 2024 12:51:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfMjfFMjJoqlPPcIkwz4rC8X1hraKxIWnwmRnXGajXepJeqEz+nr9TezFo3vs6j9Qi4kPUug== X-Received: by 2002:a05:6214:5981:b0:6cb:c508:809 with SMTP id 6a1803df08f44-6cc2b9102b8mr141606696d6.34.1729194695092; Thu, 17 Oct 2024 12:51:35 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cc2296d578sm30997736d6.129.2024.10.17.12.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 12:51:34 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 16:51:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] gdb/testsuite: introduce dwarf5 option to gdb_compile To: Tom Tromey Cc: gdb-patches@sourceware.org, Guinevere Larsen References: <20241015143847.1694961-2-guinevere@redhat.com> <20241015143847.1694961-5-guinevere@redhat.com> <87sesued5l.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87sesued5l.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/24 4:35 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> From: Guinevere Larsen > Guinevere> A few tests on the testsuite require dwarf5 to work. Up until now, the > Guinevere> way to do this was to explicitly add the command line flag -gdwarf-5. > Guinevere> This isn't very portable, in case a compiler requires a different flag > Guinevere> to emit dwarf5. > > Guinevere> This commit adds a new option to gdb_compile that would be able to add > Guinevere> the correct flag (if known) or error out in case we are unable to tell > Guinevere> which flag to use. It also changes the existing tests to use this > Guinevere> general option instead of hard coding -gdwarf-5. > > My first thought was maybe we'd want to future-proof this as well, but > in the end I think it doesn't matter -- it's fine to let these continue > to use DWARF 5 and if some compiler ever removes DWARF 5 support, (a) > I'll be retired and (b) it's easy to change to -gdwarf-23 or whatever. > > Approved-By: Tom Tromey > > Tom > Thanks for the review! Do you agree with Keith that this can be pushed independent of the rest of the series? Also, in case you're looking at patch 1, I have sent a v3 of this series (I just forgot to update the subject line of the cover letter). it's here: https://inbox.sourceware.org/gdb-patches/20241017175620.5876-2-guinevere@redhat.com/T/#t -- Cheers, Guinevere Larsen She/Her/Hers